Issue with nodenames starting with an underscore

[MartijnR]

SyntaxError: 'data>allergies>_thead>note1' is not a valid selector

See 'Form upload issue' email by @pbowen-oc on 07/17/2020.

Allergies.pab.min.underscore.xml.txt

[MartijnR]

Looks like a bug in JSDOM => jsdom/jsdom#3015

Fixing this here by going back to the old JS XPath evaluator removes performance improvements made in ccc1761

However, when we switch to the new XPath evaluator we should move from JSDOM to puppeteer anyway (which will fix this issue). May be best to move to puppeteer now.

[MartijnR]

remaining:

• failing test comment-status in non-oc mode
• some logic to close browser
• fix coverage => moved to Fix code coverage measurement #78
• refactor using async/await
• remove JSDOM entirely (also for XML structure checks?) => moved to Consider removing JSDOM entirely #79

[pbowen-oc]

@MartijnR - We're seeing the same syntax error in this case as before.

[MartijnR]

But not here, right? https://validate.enketo.org/oc/

[MartijnR]

Just in case, this is the command to check for any globally install npm packages (maybe an old enketo-validate version):

npm list -g --depth 0

This should not list enketo-validate because you've started installing it from git locally instead now I believe.

[pbowen-oc]

@MartijnR - We have an old version installed, so I'll retest once we update it.

[pbowen-oc]

Looks good in testing.