Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No relevance evaluated on 2nd iteration of a nested repeat #103

Open
yanokwa opened this issue Aug 21, 2021 · 1 comment · May be fixed by enketo/enketo-core#807
Open

No relevance evaluated on 2nd iteration of a nested repeat #103

yanokwa opened this issue Aug 21, 2021 · 1 comment · May be fixed by enketo/enketo-core#807
Labels
nested repeats repeats

Comments

@yanokwa
Copy link
Member

yanokwa commented Aug 21, 2021 •
edited
Loading

Describe the bug
Enketo v2.8.0-11-g98f7412 does not evaluate relevance on the second iteration of a nested repeat.

To Reproduce
Given a form like this:
Screen Shot 2021-08-21 at 16 10 24

I expect each iteration of field_asset_rpt to show me the nested documentation_rpt and instrumentation_rpt repeats if I select yes for documentation_exists or instrumentation_exists. In the first iteration of field asset, it works great. In the second iteration, I don't see either documentation or instrumentation repeats.

The screenshot below shows the current behavior for just the instrumentation repeat. Green arrows are the first iteration which works great and shows instrumentation. Red arrows are the second iteration which doesn't.

Screen Shot 2021-08-21 at 16 12 31

I've included test XLSForm and XML at enketo-repeat-bug.zip. The XLSForm was converted at https://getodk.org/xlsform and XML was prettified to make the XML easier for humans to read.

Expected behavior
A clear and concise description of what you expected to happen.

Browser and OS (please complete the following information):

  • OS: macOS 11.5.1
  • Browser: Chrome Version 92.0.4515.159

Additional context
Works great in Collect.
eyelidlessness referenced this issue in eyelidlessness/enketo-core Aug 30, 2021
@eyelidlessness
[Fix] Ensure nested repeats are shown when relevance is true
95b1db6 
Fixes #804.
@eyelidlessness eyelidlessness linked a pull request Aug 30, 2021 that will close this issue
Draft
@MartijnR MartijnR mentioned this issue Oct 19, 2021
Open
@vituslehner vituslehner mentioned this issue Dec 17, 2021
Open
@lognaturel
Copy link
Contributor

lognaturel commented Dec 8, 2022 •
edited
Loading

I've just run into this in this form looking at a tangentially-related issue reported by @vituslehner. That form attempt is also affected by #1028.

@lognaturel lognaturel mentioned this issue Dec 12, 2022
Closed
@lognaturel lognaturel transferred this issue from enketo/enketo-core Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nested repeats repeats
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] Ensure nested repeats are shown when relevance is true eyelidlessness/enketo-core
2 participants
@yanokwa @lognaturel