Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the user holds their phone horizontally, toolbar should go vertical and on the right (or left ?) #2

Open
enjoysmath opened this issue Dec 1, 2023 · 2 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@enjoysmath
Copy link
Owner

enjoysmath commented Dec 1, 2023

Currently: the buttons are always on top of the page regardless of the phone's orientation (horizontal / vertical).

Instead we want:

horizontal => vertical toolbar buttons on the right (or left; we need to decide what is more ergonomic)
vertical => what we currently have: horizontal tool bar at the top of the page.

Can we do this in BSS using CSS Media Queries some how?

Reason:
When the user holds their phone screen horizontal, there isn't much vertical space left to draw diagrams in.

image

@enjoysmath enjoysmath added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Dec 1, 2023
@enjoysmath
Copy link
Owner Author

enjoysmath commented Dec 4, 2023

@djpeachyclean88 @DevEnjoysMath

Clarification:

image

Note: this feature is in addition to/independent from the fact that buttons shrink / grow & navbar collapses (if we do have this navbar collapse toggle button - currently defeatured).

On large screens, the buttons will always be at the top. In version 2 it may be possible to have a user option to change toolbar position & orientation.

How can we do this? One way is media queries in CSS, which you specify from within BSS. Not sure whether there exists a better method.


Edit Just realized buttons were in the exact same position as before rotation (in above image), so it's the buttons that rotate 90 degrees the other direction, so that they're still readable normally by the user.

This is a very tricky feature, so will be helping on it.

@enjoysmath
Copy link
Owner Author

Example media query docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants