Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sidekiq] sidekiq::cleanup is invoked every chef run #350

Open
radamanthus opened this issue Dec 10, 2017 · 0 comments
Open

[Sidekiq] sidekiq::cleanup is invoked every chef run #350

radamanthus opened this issue Dec 10, 2017 · 0 comments

Comments

@radamanthus
Copy link
Contributor

https://github.com/engineyard/ey-cloud-recipes/blob/master/cookbooks/sidekiq/recipes/default.rb#L6

cleanup needs to run only when changing the instance(s) where sidekiq is run:

  • run sidekiq on utility instance instead of running on app instances
  • change the utility instance name where sidekiq is run

Basically, when this part of the recipe is changed: https://github.com/engineyard/ey-cloud-recipes/blob/master/cookbooks/sidekiq/recipes/setup.rb#L6

In practice this very rarely happens. For most cases, and especially on production environments, after the strategy (run on application or utility instances) has been set, cleanup should not be run.

Changes needed:

  • Comment out line 6 in recipes/default.rb
  • Update the README - mention that cleanup is disabled by default. Discuss the consequences: if changing the sidekiq utility name, cleanup should be run or manual cleanup should be done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant