Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OpenSSL dependency #8

Open
robinhundt opened this issue Jan 6, 2022 · 1 comment
Open

Remove OpenSSL dependency #8

robinhundt opened this issue Jan 6, 2022 · 1 comment

Comments

@robinhundt
Copy link
Contributor

OpenSSL is included in the following places:

./src/test/test_helpers.h
25:#include <openssl/rand.h>

./src/motioncore/primitives/blake2b.h
30:#include <openssl/evp.h>

./src/motioncore/primitives/sharing_randomness_generator.h

32:#include <openssl/aes.h>
33:#include <openssl/conf.h>
34:#include <openssl/err.h>
35:#include <openssl/evp.h>
36:#include <openssl/opensslv.h>

./src/motioncore/primitives/curve25519/mycurve25519.cpp
5226:#include <openssl/rand.h>

./src/motioncore/primitives/random/aes128_ctr_rng.cpp
24:#include <openssl/rand.h>

./src/motioncore/primitives/random/openssl_rng.cpp
25:#include <openssl/rand.h>

./src/motioncore/primitives/pseudo_random_generator.h

31:#include <openssl/aes.h>
32:#include <openssl/evp.h>

it seems that openssl is not only used for its blake2b implementation, but also in the implementation of different RNG's. Those seem to make use of the AES implementation of OpenSSL.
Considering this, rather than removing OpenSSL as a dependency, it might be more sensible to cross compile it for Android support (this project could help here).

@lenerd
Copy link
Collaborator

lenerd commented Jan 6, 2022

openssl-cmake looks like they just copy the OpenSSL sources into their repository and its also not up to date.

robinhundt added a commit to robinhundt/MOTION that referenced this issue Jan 14, 2022
Use openssl-cmake https://github.com/viaduck/openssl-cmake to compile and statically link OpenSSL. This will hopefully enable us to cross compile for Android.
Related: encryptogroup#8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants