RuntimeError: Cannot call "receive" once a disconnect message has been received. #123
Comments
|
@alex-oleshkevich since you seem to be the only one actively maintaining this repo and releasing 0.3 soon, is there any way you can help? |
|
|
This is a Starlette exception. Looks like your websocket had been disconnected, so it was no longer possible to read/receive messages from a closed socket. |
@alex-oleshkevich That’s the problem. It doesn’t happen when I don’t use broadcaster. It only seems to be happening with broadcaster. Client disconnected and starlette handles it gracefully and fires on disconnect. But with broadcaster it’s still listening for new messages after disconnection. What’s so messed up is that try except doesn’t work anywhere in the code that receives or sends either. |
Yes this is on the master branch. I am using the local copy of the branch instead of from the pip install. with uvicorn this error can be seen but with gunicorn it crashes right away as mentioned in #127 |
I don't see how you initialize |
|
@alex-oleshkevich apolgies for not sharing the startup code, I initiated it with await broadcast.connect() as shown in the readme. async def chatroom_ws(websocket): Isn’t this sample code right? |
|
|
@alex-oleshkevich @token.required
async def on_connect(self, websocket: WebSocket):
await websocket.accept()
user = websocket.user
room_id = websocket.query_params['room_id']
anime_id = websocket.query_params['anime_id']
websocket.anime_id = anime_id
websocket.room_id = room_id
messages = red.lrange(f"room_chat_{room_id}", 0, -1)
if not messages:
red.expire(f"room_chat_{room_id}", red_expiry)
join_message = {
"user": {
"user_id": user.user_id,
"username": user.username,
"pfp": user.get_profile_pic(),
"tier": user.tier,
"room_id": room_id,
"anime_id": anime_id,
"is_system": 1
},
"message_data": {
"text": f"@{user.username} has joined the room!",
}
}
red.lpush(f"room_chat_{room_id}", orjson.dumps(join_message).decode('utf-8'))
messages = red.lrange(f"room_chat_{room_id}", 0, 100)
data = [orjson.loads(message) for message in messages]
# tell everyone someone joined
await broadcast.publish(channel=f"room_{room_id}", message=orjson.dumps(join_message).decode('utf-8'))
# send chat data to newly joined member
await websocket.send_json(data)
# handle subscriptions using anyio and broadcaster
async with anyio.create_task_group() as task_group:
# Receiver Task
async def receiver():
await self.on_message_received(websocket=websocket)
task_group.cancel_scope.cancel()
task_group.start_soon(receiver)
task_group.start_soon(self.sender, websocket)
async def sender(self, websocket):
async with broadcast.subscribe(channel=f"room_{websocket.room_id}") as subscriber:
async for event in subscriber:
await websocket.send_json(orjson.loads(event.message))
async def on_message_received(self, websocket: WebSocket):
user = websocket.user
room_id = websocket.room_id
anime_id = websocket.anime_id
async for data in websocket.iter_json():
chat_data = {
"user": {
"user_id": user.user_id,
"username": user.username,
"pfp": user.get_profile_pic(),
"tier": user.tier,
"room_id": room_id,
"anime_id": anime_id,
"is_system": 0
},
"message_data": {
"text": data['text'],
}
}
chat_data = orjson.dumps(chat_data).decode('utf-8')
red.lpush(f"room_chat_{room_id}", chat_data)
# Publish the message to the broadcast channel
await broadcast.publish(channel=f"room_{room_id}", message=chat_data)
async def on_disconnect(self, websocket: WebSocket, close_code: int):
user = websocket.user
room_id = websocket.room_id
anime_id = websocket.anime_id
# Notify others that the user has left
leave_message = {
"user": {
"user_id": user.user_id,
"username": user.username,
"pfp": user.get_profile_pic(),
"tier": user.tier,
"room_id": room_id,
"anime_id": anime_id,
"is_system": 1
},
"message_data": {
"text": f"@{user.username} has left the room :(",
}
}
leave_message = orjson.dumps(leave_message).decode('utf-8')
red.lpush(f"room_chat_{room_id}", leave_message)
# Publish the leave message to the broadcast channel
await broadcast.publish(channel=f"room_{room_id}", message=leave_message)
print(f"Disconnected: {websocket}")The same RuntimeError is still thrown. |
|
@alex-oleshkevich i have provided the code and information. Are you not able to reproduce this? Am I the only one facing this lol |
|
Please provide me full minimal example with Starlette initialization, routes, gunicorn command which I can clone and run. |
|
Here you go @alex-oleshkevich. I spent time and created a repo with the code i am using. It has the broadcaster master repo in it as well. Issue: #127 Cause: This issue: I hope this actually helps you. |
|
@laxuscullen , ok, thank you. For #127 the fix is ready - #128 As for the second issue - I was able to repro it w/o a broadcaster. The problem may be with Starlette. Please submit a bug there. As a workaround, you can rewrite your endpoint using function style: import asyncio
import anyio
from starlette.applications import Starlette
from starlette.routing import WebSocketRoute
from starlette.websockets import WebSocket
async def ws(websocket):
await websocket.accept()
await websocket.send_json({})
async def sender():
while True:
await asyncio.sleep(1)
async def on_message_received(websocket: WebSocket):
async for data in websocket.iter_json():
print("------------ got message", data)
async with anyio.create_task_group() as task_group:
async def receiver():
await on_message_received(websocket)
task_group.cancel_scope.cancel()
task_group.start_soon(receiver)
task_group.start_soon(sender)
app = Starlette(
debug=True,
routes=[
WebSocketRoute("/ws", was),
],
) |
|
Thank you @alex-oleshkevich. I am glad I was able to help. Could you please share the code you tried to reproduce the issue w/o broadcaster? If you have it, you could create the issue or I can if you can send me the code. Once again, i thank you for your time and help with this project! |
|
Just put code of |
My code:
Stacktrace:
Using:
starlette==0.26.1
uvicorn==0.21.1 & gunicorn==20.1.0 (tested using both)
Error happens when client disconnects. I am testing using insomnia.
I tried try except, checking for client state but to no avail. I hope this project is maintained still because this is the best bet I have in implementing a room chat system.
The text was updated successfully, but these errors were encountered: