Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Installing Compound via the Emulsify CLI results in missing .scss files from the component structure. #115

Open
jimz0r opened this issue Apr 19, 2024 · 11 comments
Assignees
Labels

Comments

@jimz0r
Copy link

jimz0r commented Apr 19, 2024

Describe the bug
Installing Compound via the Emulisyf CLI (either by name or --repository --checkout options), results in missing .scss files found in the components folder. This results in a failed build/develop process due to missing index and component files (e.g /components/00-base/base.scss or components/00-base/04-spacing).

image

This is likely due to the outdated system.emulsify.json found in the project root. New .scss index files and changes to structure need to be added/updated.

To Reproduce
Steps to reproduce the behavior:

  1. Use emulsify init "MY_THEME" within a Drupal project to intirialize Emuslify theme build.
  2. Navigate to "MY_THEME"
  3. Use emulsify system install compound or emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout 2.0.0 to install the Compond system.
  4. Run npm install
  5. Run npm run develop or npm run build.

Expected behavior
After installing Compound via the Emuslify CLI, all files included in the repository should be present within the components stucture. This should result in a successful build/develop process.

Desktop

  • OS: Ubuntu 22.04.4 LTS via Windows 11 WSL 2.0
@karldivad
Copy link

I couldn't even install it, using Node 20.13.0.

Case 1:

  • Command: emulsify system install compound
  • Error: The system you attempted to install (compound) is invalid, as it does not contain a valid configuration file.
  • Folder it creates: .emulsify/cache/systems/3413609028970bcf92addcb6ca03f1f2
  • After debugging, it was looking for another folder name for some reason.

Case 2:

  • Command: emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout 2.0.1
  • Error: Unable to install system assets and/or required components: Error: ENOENT: no such file or directory, lstat '/Users/userName/.emulsify/cache/systems/34f2b669308d477ac9688a3c9b07daed/compound/components/00-base/01-colors'
  • Folder it creates: .emulsify/cache/systems/6e805b7c37e8565b3ddd400cf5040c6d
  • After debugging, it was looking for another folder name for some reason.

@franxo
Copy link

franxo commented May 15, 2024

Hi,
Same issue as @karldivad mentioned

@callinmullaney callinmullaney self-assigned this May 23, 2024
@jimz0r
Copy link
Author

jimz0r commented Jun 13, 2024

@karldivad confirmed, getting the same issue.

@bariman
Copy link

bariman commented Jun 16, 2024

getting the same issue as @karldivad , using Node 20.14.0. @callinmullaney do you have any updates on the issue?

@maheshpih
Copy link

maheshpih commented Jul 16, 2024

Hi there, facing the same issue as @bariman ...
❯ emulsify system install --repository https://github.com/emulsify-ds/compound.git --checkout 1.18.0

ERROR Unable to install system assets and/or required components: Error: ENOENT: no such file or directory, lstat '/Users/username/.emulsify/cache/systems/ba74aaaabd9722679f9a856e78fc9f80/compound/components/00-base/01-colors'

EDIT:
Strangely - it seemed to have installed Compound despite the error. It indicated so when I deleted the directory indicated in the ~/.emulsify/cache path and re-ran the install - that's when i realized that the system was indeed installed despite the error msg.

@MinhInBlack
Copy link

I am too currently experiencing this issue. It keeps looking into the incorrect folder when its generating a different folder. Has anyone found a fix yet?

@calebtr-metro
Copy link
Collaborator

I believe the hash mismatch noted by karldivad means that this likely an issue with emulsify-cli, not with compound.

@webcultist
Copy link

"The system you attempted to install (compound) is invalid, as it does not contain a valid configuration file." - everything freshly installed, I get the same error.

@callinmullaney
Copy link
Contributor

callinmullaney commented Sep 3, 2024

Hello everyone. Apologies for the delay. I have a coworker looking into this as it does appear to be sourced from the CLI and not compound. We are comparing the CLI's expected system schema (https://github.com/emulsify-ds/emulsify-cli/blob/develop/src/schemas/system.json) with Compound's system.emulsify.json using a json validator (https://www.jsonschemavalidator.net/) - As to be expected there is the following error with the CLI's schema
Error when resolving schema reference 'variant.json#/definitions/platform'. Path 'properties.variants.items.anyOf[0].properties.platform', line 49, position 27.

@deepsimran77
Copy link

I am getting the same error while installing the 'compound' system that configuration file is invalid.

@sryanb
Copy link

sryanb commented Sep 9, 2024

Same issue. This can be worked around by manually installing Compound (download the compound zip, copy files/folders into theme).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In progress
Development

No branches or pull requests