Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure to build on Arch Linux #588

Open
xiota opened this issue Sep 11, 2024 · 4 comments · May be fixed by #589
Open

Failure to build on Arch Linux #588

xiota opened this issue Sep 11, 2024 · 4 comments · May be fixed by #589

Comments

@xiota
Copy link

xiota commented Sep 11, 2024 •
edited
Loading

Describe the bug

49e9cb8 fails to build on Arch Linux. Using GCC 14.2.1. Last successful build was 46d627b (4.2.0.r355) on 2024-05-08.

Issues:

  • Vendored igraph fails to build. Succeeds when upgraded to 0.10.13.
    • But still needs system igraph to be installed?
  • System igraph is not properly found or used.
    • Probably need to adjust cmake scripts.
  • Plugins fail to build.
    • logic evaluator
    • netlist preprocessing
    • resynthesis
    • z3 utils

I didn't save logs, so would have to rebuild multiple times to recreate the errors. Before doing so, should the extra info be added to this issue or new ones?

The igraph issues may be relatively simple to fix, so I'm considering opening PRs.

To Reproduce

Try to build aur/hal-git in clean chroot on Arch Linux. Package needs to be updated, but sufficient to reproduce errors.

Adjust cmake options to observe different errors. Disable plugins with:

    -DPL_LOGIC_EVALUATOR=OFF
    -DPL_NETLIST_PREPROCESSING=OFF
    -DPL_RESYNTHESIS=OFF
    -DPL_Z3_UTILS=OFF

Expected behavior

Should build successfully.
@tmorst84
Copy link

The same for Ubuntu 22.04.3. Commit 46d627b is the last functional one as well.

@xiota xiota linked a pull request Sep 15, 2024 that will close this issue
Open
@tmorst84
Copy link

The branch builds and the result is functional. The only problem is that the plugins like dataflow_analysis are not built

@xiota
Copy link
Author

xiota commented Sep 15, 2024

The only problem is that the plugins like dataflow_analysis are not built

I enabled some previously disabled plugins because they're needed by an enabled plugin. Other disabled plugins were not changed. To build all plugins, add option to cmake when configuring: -DBUILD_ALL_PLUGINS=ON

@RenWal
Copy link
Contributor

RenWal commented Oct 14, 2024

I believe you have uncovered a larger issue here which applies beyond Arch. logic_evaluator has an incorrect build config, we shouldn't be building this plugin by default without building all of its dependencies.

Our CI didn't catch this because we build with BUILD_ALL_PLUGINS, which is not the default release configuration.

@joern274: As the code owner for the logic_evaluator plugin, could you please have a look at the default build flags for the plugin here?

hal/plugins/logic_evaluator/CMakeLists.txt

Line 1 in 936f690

option(PL_LOGIC_EVALUATOR "PL_LOGIC_EVALUATOR" ON)

We may either want to build all its dependencies by default (careful, this includes the new simulator engine and makes us dependent on Verilator by default) or rather make this plugin optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update igraph and fix build xiota/hal-emsec
3 participants
@xiota @RenWal @tmorst84