[embind] Generate better TS def for pointers. #22184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointers should be allowed to be null in the TS definitions. Fixes emscripten-core#22182
brendandahl
force-pushed
the
tsgen-pointer
branch
from
0ad7672
to
22081e7
Compare
sbc100
reviewed
Jul 3, 2024
| @@ -575,7 +583,7 @@ var LibraryEmbind = { | |||
| context, | |||
| isPureVirtual, | |||
| isAsync) { | |||
| createFunctionDefinition(methodName, argCount, rawArgTypesAddr, context, true, isAsync, (funcDef) => { | |||
| createFunctionDefinition(methodName, argCount, rawArgTypesAddr, context, true, false, isAsync, (funcDef) => { | |||
There was a problem hiding this comment.
I wonder if its time to make this function take a property bag instead of all those arguments? (As a followup?)
There was a problem hiding this comment.
Yeah, it was probably time a few arguments ago.
sbc100
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointers should be allowed to be null in the TS definitions.
Fixes #22182