[v2] Fallback MOVE by COPY+STORE+EXPUNGE doesn't return DestUIDs

[Vovan-VE]

v2.0.0-beta.3

data, err := client.Move(uidset, to).Wait()

The resulting MoveData.DestUIDs gets fulfilled only when real MOVE executed.

go-imap/imapclient/client.go

Lines 848 to 852 in ee36cf4

	if cmd := findPendingCmdByType[*MoveCommand](c); cmd != nil {
	cmd.data.UIDValidity = uidValidity
	cmd.data.SourceUIDs = srcUIDs
	cmd.data.DestUIDs = dstUIDs
	}

In case of fallback workflow COPY+STORE+EXPUNGE it remains nil.

[Vovan-VE]

Or wait, it's impossible by RFCs spec?

[emersion]

Does #624 help?

Note, these fields are only populated if the server supports UIDPLUS.

[Vovan-VE]

I'll try it and report later. Thanks!

[Vovan-VE]

I just figured out that COPY+STORE+EXPUNGE should already work fine without the PR, if underlying IMAP server supports needed features. Sorry, my fail. I'll check more details better next time.
And so DestUIDs will remein empty only when it's really nothing to put there.

However the PR itself should fix independent COPY command, isn't it?

[emersion]

The patch is supposed to fix the case where the server does not support MOVE, but does support UIDPLUS. There is nothing we can populate the fields with when the server does not support UIDPLUS.

[Vovan-VE]

Yes, right. I mean your current version without patch already should work fine as far as possible, even when it's MOVE under the hood, because Move().Wait() returns MoveData anyway. However the patch is usefull to fix independent COPY command, when CopyData is returned.

[emersion]

There's one detail though: this function handles untagged responses only. Tagged responses are handled elsewhere:

go-imap/imapclient/client.go

Line 711 in ee36cf4

case "COPYUID":

The RFC specifies that COPY results in a tagged COPYUID response, and MOVE results in an untagged COPYUID response.

[Vovan-VE]

I gathered CAPABILITIES from underlying accounts, and unfortunely I have no "test subjects" without MOVE support at the moment, so I cannot actually check if the PR does anything.