Oracle output does not support NUMBER datatype

[MichaelMih]

When trying to load to oracle using any mode (default, direct or oci) then getting 👍 Caused by: java.sql.SQLException: Unsupported type : NUMBER
at org.embulk.output.oracle.DirectBatchInsert.prepare(DirectBatchInsert.java:138)

I guess that the way to solve it is to add NUMBER in the switch statement just above DECIMAL - they both should be treated the same way.

[hito4t]

Thank you for the information!
I'll try to fix the issue.

[hito4t]

@MichaelMih
First, I tried to reproduce the issue, but I couldn't.
My Oracle (12.1.0) returns java.sql.Types.DECIMAL for the Oracle NUMBER type.

Could you tell me Oracle version, JDBC driver version and DDL?

[MichaelMih]

I checked it with oracle jdbc driver 12.1.0.1 and 12.2.0.1. The ResultSetMetaData.getColumnType of NUMBER column returns 2 - which maps to java.sql.Types.NUMERIC Sample table: create table test2(a number(1)); Sample code: PreparedStatement ps = connection.prepareStatement("select * from test2"); ResultSet rs = ps.executeQuery(); ResultSetMetaData resultSetMetaData = rs.getMetaData(); System.out.println(resultSetMetaData.getColumnType(1)); The output is: 2 the method that builds the JdbcSchema with this sqlType is: org.embulk.input.jdbc.JdbcInputConnection.getSchemaOfResultMetadata : ... int sqlType = metadata.getColumnType(index); ...

[hito4t]

@MichaelMih
Thank you for the information!

But I can't reproduce the problem yet.

As you wrote, embulk-input-jdbc uses ResultSetMetaData and it returns Types.NUMERIC.
But embulk-output-jdbc uses DatabaseMetaData, not ResultSetMetaData, and it doesn't return Types.NUMERIC in my environment.

Anyway, I've created the PR #247 to fix this issue.