-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkstyle with checkstyle 9.3 #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroyuki-sato
force-pushed
the
pr/05-update-jackson
branch
from
May 8, 2024 08:52
29d03e2
to
0ac823e
Compare
hiroyuki-sato
force-pushed
the
pr/05-update-jackson
branch
from
May 8, 2024 08:56
0ac823e
to
eb06b5c
Compare
hiroyuki-sato
force-pushed
the
pr/06-add-checkstyle
branch
2 times, most recently
from
May 8, 2024 09:12
4afcdab
to
ff46d92
Compare
hiroyuki-sato
commented
May 8, 2024
hiroyuki-sato
force-pushed
the
pr/05-update-jackson
branch
from
May 8, 2024 10:09
eb06b5c
to
b418efb
Compare
hiroyuki-sato
force-pushed
the
pr/06-add-checkstyle
branch
from
May 8, 2024 10:14
ff46d92
to
47f1a19
Compare
hiroyuki-sato
force-pushed
the
pr/06-add-checkstyle
branch
from
May 9, 2024 06:11
47f1a19
to
454b3ce
Compare
dmikurube
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left a response to your question inline.
@dmikurube Thanks. Could you double check just in case? |
dmikurube
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Still LGTM.
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.