Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkstyle with checkstyle 9.3 #15

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

hiroyuki-sato
Copy link
Member

No description provided.

@hiroyuki-sato hiroyuki-sato force-pushed the pr/05-update-jackson branch from 29d03e2 to 0ac823e Compare May 8, 2024 08:52
@hiroyuki-sato hiroyuki-sato requested a review from a team as a code owner May 8, 2024 08:52
@hiroyuki-sato hiroyuki-sato force-pushed the pr/05-update-jackson branch from 0ac823e to eb06b5c Compare May 8, 2024 08:56
@hiroyuki-sato hiroyuki-sato force-pushed the pr/06-add-checkstyle branch 2 times, most recently from 4afcdab to ff46d92 Compare May 8, 2024 09:12
@hiroyuki-sato hiroyuki-sato force-pushed the pr/05-update-jackson branch from eb06b5c to b418efb Compare May 8, 2024 10:09
@hiroyuki-sato hiroyuki-sato force-pushed the pr/06-add-checkstyle branch from ff46d92 to 47f1a19 Compare May 8, 2024 10:14
Base automatically changed from pr/05-update-jackson to master May 9, 2024 06:10
@hiroyuki-sato hiroyuki-sato force-pushed the pr/06-add-checkstyle branch from 47f1a19 to 454b3ce Compare May 9, 2024 06:11
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a response to your question inline.

src/main/java/org/embulk/input/CommandFileInputPlugin.java Outdated Show resolved Hide resolved
@dmikurube dmikurube added this to the v0.2.0 milestone May 9, 2024
@hiroyuki-sato
Copy link
Member Author

@dmikurube Thanks. Could you double check just in case?

Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Still LGTM.

@hiroyuki-sato hiroyuki-sato merged commit a40d6b9 into master May 9, 2024
4 checks passed
@hiroyuki-sato hiroyuki-sato deleted the pr/06-add-checkstyle branch May 9, 2024 08:16
@hiroyuki-sato
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants