Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jackson to 2.16.2 #14

Merged
merged 2 commits into from
May 9, 2024
Merged

Upgrade Jackson to 2.16.2 #14

merged 2 commits into from
May 9, 2024

Conversation

hiroyuki-sato
Copy link
Member

No description provided.

@hiroyuki-sato hiroyuki-sato force-pushed the pr/04-use-spi_v0_11 branch from c8aba49 to e3e7e02 Compare May 8, 2024 08:22
@hiroyuki-sato hiroyuki-sato requested a review from a team as a code owner May 8, 2024 08:22
@hiroyuki-sato hiroyuki-sato force-pushed the pr/05-update-jackson branch 2 times, most recently from 0ac823e to eb06b5c Compare May 8, 2024 08:56
@hiroyuki-sato hiroyuki-sato changed the base branch from pr/04-use-spi_v0_11 to pr/02-upgrade-gradle May 8, 2024 09:00
@hiroyuki-sato hiroyuki-sato force-pushed the pr/05-update-jackson branch from eb06b5c to b418efb Compare May 8, 2024 10:09
Base automatically changed from pr/02-upgrade-gradle to master May 9, 2024 04:56
Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It's okay this time, but let me leave a recommendation for next time -- when upgrading a dependency library, it'd be nice to have gradle.lockfile at first before upgrade, and then do the upgrade. By this order, we can confirm which library is upgraded explicitly.

Comment on lines 18 to 19


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@dmikurube
Copy link
Member

jfyi, you're one of the maintainers of this plugin now. You can merge pull requests by yourself once approved. ;)

@hiroyuki-sato hiroyuki-sato merged commit cf0dd57 into master May 9, 2024
4 checks passed
@hiroyuki-sato hiroyuki-sato deleted the pr/05-update-jackson branch May 9, 2024 06:10
@hiroyuki-sato
Copy link
Member Author

Thanks!

@dmikurube dmikurube added this to the v0.2.0 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants