Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the Gradle wrapper to 8.7, and the Gradle plugin to 0.7.0 #11

Merged
merged 4 commits into from
May 9, 2024

Conversation

hiroyuki-sato
Copy link
Member

Could you tell me how to fix this warning?

org.embulk.input.TestCommandFileInputPlugin > testShell STANDARD_ERROR
    Hidden dependencies are uninitialized. Maybe using classes loaded by Embulk's top-level ClassLoader.
    SLF4J: No SLF4J providers were found.
    SLF4J: Defaulting to no-operation (NOP) logger implementation
    SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.

Base automatically changed from pr/01-bump-version to master May 8, 2024 06:11
@dmikurube
Copy link
Member

That warning has no problems. It means that the code is writing logs by SLF4J, but no actual logging driver is found, then it is logging nothing out.

If you wanted to elimiate this warning, and write logs in tests, you may want to include Logback in the test dependencies.

Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When making a pull request (or split multiple pull requests), it'd be nice to keep each pull request to pass compile and tests. Unfortunately, this pull request does not compile, and pass the tests.

To keep each pull request to pass compile and tests, you may want to have the check GitHub Action at first.

@dmikurube
Copy link
Member

Made check in #17.

@hiroyuki-sato
Copy link
Member Author

Thanks. After merging #17. I'll modify something and push again. As a result, I expect CI will run.

@hiroyuki-sato hiroyuki-sato force-pushed the pr/02-upgrade-gradle branch from d2a5f4e to 07eec69 Compare May 8, 2024 08:14
@hiroyuki-sato hiroyuki-sato requested a review from a team as a code owner May 8, 2024 08:14
@hiroyuki-sato
Copy link
Member Author

hiroyuki-sato commented May 8, 2024

Due to I haven't changed the Java code yet, CI (#11, #12) fail. I fixed the source codes in #13. It passed CI test.

@dmikurube
Copy link
Member

CI should pass in each pull request. It is prioritized than splitting pull requests for readability. If this #11 needs code changes in #13, please consider :

This was referenced May 8, 2024
@dmikurube
Copy link
Member

Thanks. Allow me to have some time to review this...

Copy link
Member

@dmikurube dmikurube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, then approved, but left a couple of nitpicking comments. Thanks for working on it!

build.gradle Outdated Show resolved Hide resolved
build.gradle Show resolved Hide resolved
}
}

@VisibleForTesting
static List<String> buildShell()
protected static List<String> buildShell()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protected needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I wanted to ask how to remove the @VisibleForTesting annotation. Fixed.

@dmikurube dmikurube merged commit 86991ce into master May 9, 2024
4 checks passed
@dmikurube dmikurube deleted the pr/02-upgrade-gradle branch May 9, 2024 04:56
@dmikurube dmikurube added this to the v0.2.0 milestone May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants