Change starting slot for treeview position from 0 to 1 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Side comment: Even after this change, it seems to resize the lsp-metals treeview to take up half of the treeview window. I would prefer if it didn't change the size of the window so I could keep it shrunk down so it doesn't cover half of the file tree since the compilation progress only takes a max of a few lines anyway. Any ideas on how to do this? |
|
I'm going to close this due to discussion in the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
I changed the constant to 1 here at both callsites but could also just add 1 to it in the
lsp-metals-treeview--show-viewsfunction instead.This also does change the behavior from replacing the file tree buffer (which I guess is slot 0 by default) to opening a new window under it. I feel like this is a positive (and hopefully uncontroversial) change, but can imagine why it might be something a user would want to configure.