Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EpochTime.getCurrent() doesn't appear to return valid subSeconds value #23

Open
gcohler opened this issue Sep 22, 2024 · 4 comments
Open

EpochTime.getCurrent() doesn't appear to return valid subSeconds value #23

gcohler opened this issue Sep 22, 2024 · 4 comments
Assignees
@biosbob
Labels
bug Something isn't working
Milestone
v25.0.3

Comments

@gcohler
Copy link
Collaborator

gcohler commented Sep 22, 2024

It's not clear to me, but it seems as though the subSeconds value is not valid.
@gcohler gcohler added the bug Something isn't working label Sep 22, 2024
@biosbob biosbob added this to the v25.0.3 milestone Sep 23, 2024
@biosbob
Copy link
Member

biosbob commented Sep 23, 2024

will add methods into EpochTime which convert (secs, subs) into milleseconds

biosbob added a commit that referenced this issue Sep 23, 2024
@biosbob
EpochTime.getCurrent() doesn't appear to return valid subSeconds value
69651d4 
Fixes #23
@biosbob biosbob mentioned this issue Sep 23, 2024
Merged
gcohler pushed a commit that referenced this issue Sep 23, 2024
@biosbob
EpochTime.getCurrent() doesn't appear to return valid subSeconds value (
ec4ccac 
#26)

Fixes #23
@gcohler
Copy link
Collaborator Author

gcohler commented Sep 23, 2024

Added new subSecondsToMs method that returns milliseconds -- which is more comprehensible.

@gcohler gcohler closed this as completed Sep 23, 2024
@biosbob
Copy link
Member

biosbob commented Sep 24, 2024

this method needs to move into some interface – either UptimerI or WakeupTimerI.... we can use the former (for now) since EpochTime uses a proxy of that type....

@biosbob biosbob reopened this Sep 24, 2024
@gcohler
Copy link
Collaborator Author

gcohler commented Sep 24, 2024

I'd suggest making a new issue for the new changes. But that's up to you.

@biosbob biosbob mentioned this issue Oct 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@biosbob biosbob

Labels
bug Something isn't working
Projects
None yet
Milestone
v25.0.3
Development

No branches or pull requests
2 participants
@gcohler @biosbob