Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail to create new project #414

Open
dyaskur opened this issue Apr 19, 2024 · 4 comments
Open

Fail to create new project #414

dyaskur opened this issue Apr 19, 2024 · 4 comments

Comments

@dyaskur
Copy link

dyaskur commented Apr 19, 2024

I tried to run skeet new and return below error:

skeet new
? Enter the name of the app skeet-app
🚛 Downloading base template...📦 ⠼node:internal/process/promises:289
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[Error: ENOENT: no such file or directory, open 'skeet-app/package.json'] {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'skeet-app/package.json'
}

Node.js v20.11.1

My OS is macOS Sonoma m1

@POPPIN-FUMI
Copy link
Contributor

Which version are you using?
I tried it, and it works with the latest version!

skeet -V
2.2.23

@dyaskur
Copy link
Author

dyaskur commented Apr 20, 2024

I used skeet latest version also. Previously I have pnpm problem, but fixed by :

mkdir -p ~/.pnpm/store
export PNPM_HOME=~/.pnpm/store
pnpm setup
source ~/.zshrc

I got that command from pnpm/pnpm#5883 (comment)

does it related to my current problem?

@dyaskur
Copy link
Author

dyaskur commented Apr 21, 2024

After debugging this repository, I've discovered that the issue stems from wget not being installed on my computer. It's puzzling why the process continues despite the download failure. Additionally, considering that macOS and windows comes with curl pre-installed and most Linux distributions also have it readily available, it raises the question: why are we using wget instead of curl?

I'm planning to submit a pull request to switch to CURL and include error messages for download failures. There are various reasons downloads can fail, such as missing curl/wget, blocked URLs, URL not found, or connectivity issues. Would that be alright?

Furthermore, I've noticed numerous inconsistencies in variable names and some code duplications. If permissible, I'd like to undertake a refactoring effort to address these issues as well.

@POPPIN-FUMI
Copy link
Contributor

Hello,

Thank you for the report! I've also reviewed your pull request and appreciate the excellent work.

We have a Discord chat where we discuss our open-source software projects, and I'd like to invite you to join us there. Here's the link: Discord Chat.

I'm planning to integrate Vitest into this repository. Given that we're transitioning from Skeet v2 to v3, a significant amount of refactoring is necessary. It would be great to discuss this further on our Discord thread.

Thank you very much for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants