Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove URL encode from uri.py. #24

Open
cpommier opened this issue Dec 23, 2019 · 3 comments
Open

Remove URL encode from uri.py. #24

cpommier opened this issue Dec 23, 2019 · 3 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cpommier
Copy link
Member

This is used in Elastic search cache. Ids are base64 encoded, so likely useless and breaking a lot of things.

@cpommier cpommier self-assigned this Dec 23, 2019
@cpommier cpommier added bug Something isn't working good first issue Good for newcomers labels Dec 23, 2019
@sumit-158
Copy link

Hey, @cpommier can I work on this!! And can you help me out what I have to remove?

@cpommier
Copy link
Member Author

Hi @sumit-158 , thanks a lot for voluntering ! I'll get back to you ASAP to give you more information.

@cpommier
Copy link
Member Author

cpommier commented Feb 2, 2022

Thanks @sumit-158
Here are some starter info:
The code to modify is in uri.py .
There is some unit test available. But the most reliable is probably the integration test available in common test folder.

The Identifiers generated were encoded in base64 to avoid tomact security issues. This approach seemed deprecated two years ago and it was better not to encode. But I would need to check a couple of things first. The code has moved in two years, and this might be handled diferently now. I'll get back to you ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants