-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testing with other implementations of TES (other than funnel) #15
Comments
I think tests should be added continuously with each code change, not after code was merged. Otherwise it tends not to get done. For our other projects, we generally make the availability of comprehensive tests a prerequisite for changes to be merged (with very few exceptions for toy/sandbox code), and I think this is a good idea here as well. Same with documentation, see: See #16 (comment) |
Currently, I have already made the unit tests using Funnel. How many other implementations of TES do you think should be used for tests?
|
None. In fact, for most tests (unit and integration), you don't really need external services at all. Consider mocking responses from external dependencies instead. After all, we want to tese our code, not theirs, and you could easily get failing tests through no fault of yours - especially if the network is involved. It's fine to keep Funnel for end to end tests. It is of course nice to know that we actually get expected responses for our requests from real services. |
This is issue is in reference to #13 (comment)
Currently, the codebase uses Funnel for unit testing. Since it might not be healthy to tightly couple one specific implementation with a generic library, we should use multiple implementation for testing purposes.
The text was updated successfully, but these errors were encountered: