-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move machine learning code into utils class #1825
Comments
@nya-elimu May I be allowed to pick this up? |
@Aryant-Tripathi Please do! 🙂 |
Hey, @nya-elimu Method I guess refactoring the method into some smaller methods, and extracting things into utility files and fetching some data by making them environment variables would be helpful, but it seems it will take too much of effort and we need to create test cases for the same also. |
@Aryant-Tripathi I think the task here would be to only move the code related to the machine learning model inference, i.e. the |
- Refactored `predictReadingLevel` method from core class into `PredictionUtils` to enhance reusability and separation of concerns. - The utility class no longer includes logging statements. - Add unit test cases for ReadingFileUtil class. - Create a ReadingLevelConstants class which will be responsbile for containing all constants related to Reading level. Issue elimu-ai#1825
- Refactored the predictReadingLevel method from core class into PredictionUtils to enhance reusability and separation of concerns. - The utility class no longer includes logging statements, adhering to best practices. - Added a ReadingLevelConstants class responsible for containing all constants related to the Reading Level ML model. - Added unit test cases for ReadingLevelUtil class. Issue elimu-ai#1825
For better separation of concerns, move the code for calling the machine learning model from
StoryBookCreateFromEPubController
into its own utils class in a newai.elimu.util.ml
package. Also move the PMML file tosrc/main/resources/ai/elimu/util/ml
, and add unit tests for covering the code in the new utils class.The text was updated successfully, but these errors were encountered: