-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename LetterSoundCorrespondence
to LetterSound
#1677
Comments
Hi, can I take up this issue? |
@SnehaHS65 Yes, please do 🙂 |
This reverts commit 35093ef.
…erSound" This reverts commit 53371c0.
Rename Word's property `letterSoundCorrespondences` to `letterSounds`. refs #1677
Should be `DROP FOREIGN KEY` refs #1677
@SnehaHS65 After running the DB migration script, I just realized that ALTER TABLE `LetterSound_Letter` DROP COLUMN `LetterSound_id`; and ALTER TABLE `LetterSound_Sound` DROP COLUMN `LetterSound_id`; will not work because they don't exist. These columns do get created automatically, but only in the new empty tables |
Done: [HIN] 05:53:05.488 [main] INFO ai.elimu.util.db.DbMigrationHelper - Migration script found for version 2004022
[HIN] 05:53:05.488 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: DROP TABLE IF EXISTS `LetterSound`;
[HIN] 05:53:05.499 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: ALTER TABLE `LetterSoundCorrespondence` RENAME TO `LetterSound`;
[HIN] 05:53:05.503 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: DROP TABLE IF EXISTS `LetterSound_Letter`;
[HIN] 05:53:05.505 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: ALTER TABLE `LetterSoundCorrespondence_Letter` RENAME TO `LetterSound_Letter`;
[HIN] 05:53:05.509 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: ALTER TABLE `LetterSound_Letter` CHANGE `LetterSoundCorrespondence_id` `LetterSound_id` bigint(20) NOT NULL;
[HIN] 05:53:05.515 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: DROP TABLE IF EXISTS `LetterSound_Sound`;
[HIN] 05:53:05.519 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: ALTER TABLE `LetterSoundCorrespondence_Sound` RENAME TO `LetterSound_Sound`;
[HIN] 05:53:05.524 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: ALTER TABLE `LetterSound_Sound` CHANGE `LetterSoundCorrespondence_id` `LetterSound_id` bigint(20) NOT NULL;
[HIN] 05:53:05.536 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: DROP TABLE IF EXISTS `Word_LetterSound`;
[HIN] 05:53:05.541 [main] INFO ai.elimu.util.db.DbMigrationHelper - Executing sql: ALTER TABLE `Word_LetterSoundCorrespondence` RENAME TO `Word_LetterSound`;
[HIN] 05:53:05.545 [main] INFO ai.elimu.util.db.DbMigrationHelper - Updating current version (2004022)
[HIN] 05:53:05.550 [main] INFO ai.elimu.util.db.DbMigrationHelper - Database migration complete! @SnehaHS65 Your changes are now in production (http://hin.elimu.ai/ + http://tgl.elimu.ai/), and from what I can see everything is running smoothly. Thank you very much for putting so much time and effort into this change, which I think helped make the code more simple and easier to work with. |
Rename the
LetterSoundCorrespondence
entity.From
LetterSoundCorrespondence.java
toLetterSound.java
.LetterSoundPeerReviewEvent#letterSoundContributionEvent
refactor(dao): LetterSoundCorrespondencePeerReviewEvent#letterSoundCo… #1719
LetterSoundContributionEvent#letterSound
refactor(dao): LetterSoundCorrespondenceContributionEvent#letterSounds #1717
LetterSoundPeerReviewEvent
refactor(dao): LetterSoundPeerReviewEvent #1721
LetterSoundContributionEvent
refactor(dao) : LetterSoundContributionEvent #1677 #1724
Word#letterSounds
refactor(dao): Rename
letterSoundCorrespondences
#1713LetterSound
refactor(dao) : LetterSound #1677 #1725
The text was updated successfully, but these errors were encountered: