Simple ISO verification hashing done on the client #3189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RMcNeely I am curious. Could you imagine showing a visual glimpse of the actual state of your POC? |
|
I can add something to show progress but I'm not sure that the way it is written I can easily add a progress bar given that the APIs are async. I would need to rewrite the file read operation to use chunks but to my knowledge, there's no way to do chunking on the hash creation so at best you would have a progress bar for only one part of the workflow. I think it would be simpler to add a message that changes with the different steps of the verification process. Something like:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3179
Initial pass at providing a client-side way to verify the downloaded ISO file. Needs a lot more love but posting as a POC so someone with an x86 computer can validate.
Changes Summary
This pull request is a draft that needs UI review