Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many deprecation warnings during install caused by node-gyp dependency #8726

Open
crystalfp opened this issue Dec 6, 2024 · 1 comment
Open

Comments

@crystalfp
Copy link

  • Electron-Builder Version: 25.1.8
  • Node Version: 22.5.1
  • Electron Version: 33.2.1
  • Electron Type (current, beta, nightly): current
  • Target: Windows

During electron-builder installation many deprecation warnings appear:

npm warn deprecated @npmcli/[email protected]: This functionality has been moved to @npmcli/fs
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: Rimraf versions prior to v4 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: Glob versions prior to v9 are no longer supported
npm warn deprecated [email protected]: This package is no longer supported.

Seems that these warnings are generated by the use of a not up-to-date version of node-gyp. Could this dependency be updated?

@mmaietta
Copy link
Collaborator

mmaietta commented Dec 6, 2024

I think those are coming from @electron/node-gyp package that is the official package for building native node modules, I don't think there's anything I can do from the electron-builder side

That being said, I only checked a few of them though.

mm@MBP ~/D/electron-builder-test-2> yarn why rimraf
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "rimraf"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "rimraf"
info Reasons this module exists
   - Hoisted from "sqlite3#node-gyp#rimraf"
   - Hoisted from "eslint#file-entry-cache#flat-cache#rimraf"
   - Hoisted from "sqlite3#node-gyp#make-fetch-happen#cacache#rimraf"
   - Hoisted from "electron-builder#app-builder-lib#@malept#flatpak-bundler#tmp-promise#tmp#rimraf"
   - Hoisted from "sqlite3#node-gyp#make-fetch-happen#cacache#@npmcli#move-file#rimraf"
   - Hoisted from "electron-builder#app-builder-lib#@electron#rebuild#@electron#node-gyp#make-fetch-happen#cacache#rimraf"
   - Hoisted from "electron-builder#app-builder-lib#@electron#rebuild#@electron#node-gyp#make-fetch-happen#cacache#@npmcli#move-file#rimraf"
info Disk size without dependencies: "32KB"
info Disk size with unique dependencies: "96KB"
info Disk size with transitive dependencies: "336KB"
info Number of shared dependencies: 8
=> Found "patch-package#[email protected]"
info This module exists because "patch-package" depends on it.
info Disk size without dependencies: "28KB"
info Disk size with unique dependencies: "92KB"
info Disk size with transitive dependencies: "332KB"
info Number of shared dependencies: 8
✨  Done in 0.10s.
mm@MBP ~/D/electron-builder-test-2> yarn why glob  
yarn why v1.22.19
[1/4] 🤔  Why do we have the module "glob"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "[email protected]"
info Has been hoisted to "glob"
info Reasons this module exists
   - Hoisted from "rimraf#glob"
   - Hoisted from "patch-package#rimraf#glob"
   - Hoisted from "sqlite3#node-gyp#glob"
   - Hoisted from "electron-builder#app-builder-lib#@electron#asar#glob"
   - Hoisted from "sqlite3#node-gyp#make-fetch-happen#cacache#glob"
info Disk size without dependencies: "64KB"
info Disk size with unique dependencies: "232KB"
info Disk size with transitive dependencies: "304KB"
info Number of shared dependencies: 8
=> Found "config-file-ts#[email protected]"
info This module exists because "electron-builder#app-builder-lib#config-file-ts" depends on it.
info Disk size without dependencies: "624KB"
info Disk size with unique dependencies: "2.97MB"
info Disk size with transitive dependencies: "3.94MB"
info Number of shared dependencies: 22
=> Found "@electron/node-gyp#[email protected]"
info Reasons this module exists
   - "electron-builder#app-builder-lib#@electron#rebuild#@electron#node-gyp" depends on it
   - Hoisted from "electron-builder#app-builder-lib#@electron#rebuild#@electron#node-gyp#make-fetch-happen#cacache#glob"
info Disk size without dependencies: "68KB"
info Disk size with unique dependencies: "220KB"
info Disk size with transitive dependencies: "292KB"
info Number of shared dependencies: 7
✨  Done in 0.12s.

Additional note, Renovate tracks all dependencies in electron-builder that require updating #6183

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants