Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify CSS and JS in HTMLGenerator #31

Open
tapickell opened this issue Dec 21, 2015 · 4 comments
Open

Minify CSS and JS in HTMLGenerator #31

tapickell opened this issue Dec 21, 2015 · 4 comments

Comments

@tapickell
Copy link
Contributor

Just an idea that could simplify things a bit.

Currently we have rake tasks compile_js and compile_css
https://github.com/electric-it/minimart/blob/master/Rakefile#L18-L44
That will uglify and minify the JS and CSS files from the _assets dir to the assets dir.
In the HTMLGenerator class we are copying those assets over into the web directory as part of the static site creation.
https://github.com/electric-it/minimart/blob/master/lib/minimart/web/html_generator.rb#L34

It seems like this may be a good place to have it minify & uglify the CSS and JS files for us during the site generation process instead of relying on the rake task.

What do you think @richardardrichard @ge1st @berniedurfee-ge

@richardardrichard
Copy link
Contributor

I honestly don't have a good reason why it's not a part of that already...

@tapickell
Copy link
Contributor Author

Cool, I looked at that and was just like, hmmm.... why aren't we doing that.

@tapickell
Copy link
Contributor Author

I will work on adding that today.

@richardardrichard
Copy link
Contributor

I think I was trying to avoid adding those things as dependencies... which doesn't really make sense at all.... so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants