Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sailor enhancement: set custom timeout length with env variable #115

Open
4 tasks
hannah-bulmer opened this issue Nov 11, 2019 · 1 comment
Open
4 tasks

Comments

@hannah-bulmer
Copy link

hannah-bulmer commented Nov 11, 2019

Right now, Sailor has a static timeout time of 20 minutes, before it automatically calls a forceful program termination.

Two enhancements here could be made:

  • throw an error in Sailor if the timeout time is ever reached, rather than quietly ending the program
  • refactor the TIMEOUT value into an optional environment variable, with a default time of 20 minutes. The purpose of this is that the current timeout time is quite arbitrary, and may be useful in some situations to be able to change this value

Changes to make for this enhancement:

  • make Sailor throw a descriptive error when the timeout has been reached
  • add a SAILOR_TIMEOUT env variable to the settings with a default value of 20 minutes
  • use this variable in the timeout functions instead of the static one
  • investigate if anything on the platform side needs to be changed regarding environment variables???
@hannah-bulmer
Copy link
Author

Investigate how much Admiral is affecting this timeout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant