You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are two different cases that need to be handled for this issue:
verifyCredentials
Right now, both throwing an error and emitting an error successfully will mark the provided credentials as incorrect, but an error message does not display to the platform in either case.
For example,
verify(credentials){this.emit('error','Credentials are invalid');thrownewError('Credentials are not working!!');}
will both mark the credentials are invalid, but in both cases the logs will not show any sort of error.
This has been further discussed in these issues: #58 #68
For this issue to be resolved,
emitting an error from verify should both invalidate the credentials and display the error message
throwing an error from verify should both invalidate the credentials and display the error message
init, startup, shutdown
Building off of #112, for these three functions it should be investigated and discussed whether we should implement emit error. If we are not implementing emit error for this function at this time, it should be noted in documentation that these functions are not currently supported
investigate if any platform changes would be needed
implement the change, or add documentation accordingly
The text was updated successfully, but these errors were encountered:
hannah-bulmer
changed the title
Sailor enhancement/bug: emitting errors should work, and display to the platform
Sailor enhancement/bug: emitting errors should work, and they should be displayed on the platform
Nov 11, 2019
hannah-bulmer
changed the title
Sailor enhancement/bug: emitting errors should work, and they should be displayed on the platform
Emitting errors should work, and they should be displayed on the platform
Nov 11, 2019
There are two different cases that need to be handled for this issue:
verifyCredentials
Right now, both throwing an error and emitting an error successfully will mark the provided credentials as incorrect, but an error message does not display to the platform in either case.
For example,
will both mark the credentials are invalid, but in both cases the logs will not show any sort of error.
This has been further discussed in these issues:
#58
#68
For this issue to be resolved,
verify
should both invalidate the credentials and display the error messageverify
should both invalidate the credentials and display the error messageinit, startup, shutdown
Building off of #112, for these three functions it should be investigated and discussed whether we should implement
emit error
. If we are not implementingemit error
for this function at this time, it should be noted in documentation that these functions are not currently supportedFor this issue to be resolved,
this.emit('error')
for these functions - also see Add logger to init, startup, shutdown #109The text was updated successfully, but these errors were encountered: