Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Reuse existing mongoose connection #3

Open
ulanmurzatayev opened this issue Feb 22, 2019 · 1 comment
Open

[Feature Request] Reuse existing mongoose connection #3

ulanmurzatayev opened this issue Feb 22, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ulanmurzatayev
Copy link

I think it makes sense to give this adapter ability to reuse existing mongoose connection during creation, because it usually already exists in the application using this adapter.

@ghaiklor ghaiklor added enhancement New feature or request help wanted Extra attention is needed labels Apr 8, 2019
@ghaiklor
Copy link
Contributor

ghaiklor commented Apr 8, 2019

The point behind using a separate mongoose connection pool is compatibility. In case, there is some consumer that uses a really old mongoose version, it can be not compatible with the features I am using here in the adapter.

If you have any ideas on how to move mongoose in peerDependencies - feel free to open the PR.

BTW, we actually, can move mongoose in peerDependencies and a question of compatibility leave to the consumer of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants