Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs processor is not emitting event.dataset some UIs do not work properly #106

Open
bvader opened this issue Oct 18, 2024 · 3 comments
Open
Labels
bug Something isn't working

Comments

@bvader
Copy link

bvader commented Oct 18, 2024

Bug Report

Which version of the demo you are using? (please provide either a specific
https://github.com/elastic/opentelemetry-demo/tree/1.11.5

Symptom

logs processor is not emitting event.dataset some UI do not work properly

What is the expected behavior?

logs processor should emit event.dataset

What is the actual behavior?

event.dataset is missing

Reproduce

Run the otel demo add the metrics and logs daemonset.

Fix

This line should have attributes/dataset as part of the list of processors

processors: [batch, k8sattributes, resourcedetection/system, resourcedetection/eks, resourcedetection/gcp, resource/demo, resource/k8s, resource/cloud, attributes/k8s_logs_dataset]

Is

processors: [batch, k8sattributes, resourcedetection/system, resourcedetection/eks, resourcedetection/gcp, resource/demo, resource/k8s, resource/cloud, attributes/k8s_logs_dataset]

Should be

processors: [batch, k8sattributes, resourcedetection/system, resourcedetection/eks, resourcedetection/gcp, resource/demo, resource/k8s, resource/cloud, attributes/k8s_logs_dataset, attributes/dataset]

@bvader bvader added the bug Something isn't working label Oct 18, 2024
@bvader bvader changed the title logs processor is not emitting event.dataset some UI do not work properly logs processor is not emitting event.dataset some UIs do not work properly Oct 18, 2024
@bvader
Copy link
Author

bvader commented Dec 4, 2024

@rogercoll Just pinging on this I am getting more interest and this bug is creeping in causing issues, do you want me to create a PR etc?

@rogercoll
Copy link
Collaborator

@rogercoll Just pinging on this I am getting more interest and this bug is creeping in causing issues, do you want me to create a PR etc?

Sorry for my late response, a PR would be great, but I think this attribute decoration is not needed anymore with the otel native data model. I am about to merge this PR that changes the Otel demo deployment within Elastic completely to be Otel native: #120 (so this decoration won't be needed)

@rogercoll
Copy link
Collaborator

@bvader Could you share more details of which UIs do not work properly?

I was checking the sample configurations we are shipping with the elastic-agent (EDOT collector) and it does not contain this attribute decoration, reference: https://github.com/elastic/elastic-agent/blob/v8.16.0/internal/pkg/otel/samples/linux/logs_metrics_traces.yml#L142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants