Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/signaltometrics] Handle OTTL error mode #173

Open
lahsivjar opened this issue Oct 9, 2024 · 2 comments
Open

[connector/signaltometrics] Handle OTTL error mode #173

lahsivjar opened this issue Oct 9, 2024 · 2 comments

Comments

@lahsivjar
Copy link
Contributor

OTTL provides error modes which could configure how OTTL error modes are handled by the component. We should take the error mode as a configuration in the component and use it for changing the behavior.

@lahsivjar
Copy link
Contributor Author

@axw Confirming if I am on the same page, we would be taking an error mode as a configuration and handling it in our code in the signaltometrics to:

  1. Log any errors if error mode is ignore
  2. Silently discard errors if error mode is silent
  3. Propagate errors and stop next processing on OTTL errors if error mod is propagate

Also, what would the scope be for handling the error codes? Do we limit it to evaluating the OTTL expressions or extend it to parsing too?

I am also undecided on whether to use the OTTL error mode (as it applies to condition and statement sequence parsing only) or just have a custom configuration for our component.

@axw
Copy link
Member

axw commented Oct 16, 2024

Confirming if I am on the same page, we would be taking an error mode as a configuration and handling it in our code in the signaltometrics to:

  1. Log any errors if error mode is ignore
  2. Silently discard errors if error mode is silent
  3. Propagate errors and stop next processing on OTTL errors if error mod is propagate

Sounds right.

Also, what would the scope be for handling the error codes? Do we limit it to evaluating the OTTL expressions or extend it to parsing too?

I think config parsing should always be a fast-fail. The error mode would only affect runtime behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants