-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSL Breaking changes for logstash-output-http to breaking changes… #16701
base: main
Are you sure you want to change the base?
Conversation
I like the idea here. For all the other plugins we will continue with sections that have the plugin name and the obsolete parameters. Looks like the docs build is red. The only thing I saw in the logs is a warning about use of headers. Not sure if that is the cause. Once we get this base example sorted out we can start making sure the other plugins get a similar treatment :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left suggestions and broader guidelines inline.
Let's discuss and iterate. When we agree, let's apply these style guidelines for the other 10 plugins with changes to SSL settings.
Co-authored-by: Karen Metts <[email protected]>
Doc Preview: |
|
||
We've removed deprecated SSL settings in some {ls} plugins, and have replaced them with updated settings. | ||
If your plugin configuration contains any of these obsolete options, the plugin may fail to start. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Click the arrow beside a plugin name to see the list of settings that have been | |
removed and their replacements. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expandable content is a common UI element, and we use it extensively throughout our docs. If you think we need to call it out here's a suggestion for how and where to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'm good with skipping it. If there is plenty of prior art of us using the control, and not having any explanatory text, then I'm good
|
||
[discrete] | ||
[[output-http-ssl-9.0]] | ||
.<<plugins-outputs-http,logstash-output-http>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.<<plugins-outputs-http,logstash-output-http>> | |
.`logstash-output-http` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the plugin docs added confusion and seems like overkill. All of the links in the dropdown content take users to the plugin docs anyway.
… doc
PREVIEW: https://logstash_bk_16701.docs-preview.app.elstc.co/guide/en/logstash/master/breaking-changes.html