Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Diff view incorrectly highlights changes in multiline strings #202016

Open
Tracked by #201502
xcrzx opened this issue Nov 27, 2024 · 3 comments · May be fixed by #205138
Open
Tracked by #201502

[Security Solution] Diff view incorrectly highlights changes in multiline strings #202016

xcrzx opened this issue Nov 27, 2024 · 3 comments · May be fixed by #205138
Assignees
@nikitaindik
Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0

Comments

@xcrzx
Copy link
Contributor

xcrzx commented Nov 27, 2024 •
edited by nikitaindik
Loading

PR: #205138

Summary

When upgrading rules, the diff view displays changes in the wrong places when comparing multiline strings.

Example

Here’s an example of the changes in the ESQL field:

image

The removed parts (in bold) are misplaced. For comparison, here’s how the same diff appears in an external diff tool:

image
@xcrzx xcrzx added 8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team v8.18.0 v9.0.0 labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management)

@xcrzx xcrzx added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Nov 28, 2024
@banderror banderror self-assigned this Nov 28, 2024
@banderror banderror added triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed triage_needed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v9.0.0 v8.18.0 labels Nov 28, 2024
@banderror banderror removed their assignment Dec 4, 2024
@banderror banderror mentioned this issue Dec 4, 2024
Open
@maximpn maximpn assigned maximpn and nikitaindik and unassigned maximpn Dec 6, 2024
@nikitaindik nikitaindik linked a pull request Dec 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikitaindik nikitaindik

Labels
8.18 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules area impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Fix incorrect changes highlighting in diff view nikitaindik/kibana
5 participants
@xcrzx @maximpn @banderror @elasticmachine @nikitaindik