Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging to Event Log for install, uninstall, and enroll subcommands #6338

Open
leehinman opened this issue Dec 13, 2024 · 1 comment · May be fixed by #6410
Open

Add logging to Event Log for install, uninstall, and enroll subcommands #6338

leehinman opened this issue Dec 13, 2024 · 1 comment · May be fixed by #6410
Assignees
@leehinman
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Comments

@leehinman
Copy link
Contributor

leehinman commented Dec 13, 2024 •
edited
Loading

Currently we log to the Event Log if the run subcommand fails under Windows. This has been useful in capturing errors from the Windows Service Manager. We should add this same logging to the install, uninstall, and enroll sub-commands. These commands can often be run from DevOps software that make it hard to capture the error.

Code similar to

elastic-agent/internal/pkg/agent/cmd/run.go

Line 92 in 1eeb722

logExternal(fmt.Sprintf("%s run failed: %s", paths.BinaryName, err))
should be added to install and uninstall
@leehinman leehinman added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 13, 2024
@leehinman leehinman self-assigned this Dec 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@leehinman leehinman changed the title Add logging to Event Log for install & uninstall Add logging to Event Log for install, uninstall, and enroll subcommands Dec 13, 2024
@leehinman leehinman linked a pull request Dec 19, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leehinman leehinman

Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add logging to EventLog for error, install, uninstall leehinman/elastic-agent
2 participants
@elasticmachine @leehinman