{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":512187504,"defaultBranch":"main","name":"EICrecon","ownerLogin":"eic","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2022-07-09T13:03:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/62705204?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725654805.0","currentOid":""},"activityList":{"items":[{"before":"faf9654e448870f3d2021c41f430ae9ceddd0499","after":"85cadb01df0a1bb15e57b51d430bdb5407df94eb","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-09-06T21:29:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Fix weighting","shortMessageHtmlLink":"Fix weighting"}},{"before":"e5f8f9644b0b7b323df21b26e471a6d805f25491","after":"341d230701202128fed572a4fc47f2e3444816b6","ref":"refs/heads/pr/primaryvertices","pushedAt":"2024-09-06T20:45:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pre-commit-ci[bot]","name":null,"path":"/apps/pre-commit-ci","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/68672?s=80&v=4"},"commit":{"message":"[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci","shortMessageHtmlLink":"[pre-commit.ci] auto fixes from pre-commit.com hooks"}},{"before":"7f8feba7572a7b05cab02027929cd08659b1cdbd","after":"e5f8f9644b0b7b323df21b26e471a6d805f25491","ref":"refs/heads/pr/primaryvertices","pushedAt":"2024-09-06T20:41:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"starsdong","name":"Xin Dong","path":"/starsdong","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11791288?s=80&v=4"},"commit":{"message":"added PrimaryVertices factory (subCollection of CentralTrackVertices)","shortMessageHtmlLink":"added PrimaryVertices factory (subCollection of CentralTrackVertices)"}},{"before":null,"after":"7f8feba7572a7b05cab02027929cd08659b1cdbd","ref":"refs/heads/pr/primaryvertices","pushedAt":"2024-09-06T20:33:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"starsdong","name":"Xin Dong","path":"/starsdong","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11791288?s=80&v=4"},"commit":{"message":"feat: produce *RawHitAssociations in CalorimeterHitDigi (#1601)\n\n### Briefly, what does this PR introduce?\nThis PR modifies CalorimeterHitDigi to produce raw hit associations\n(i.e. assocations from raw hits back to sim hits, and then from there\nMCParticles). The weighting is done based on total energy, and only\nnon-trivial when merging hits.\n\n### What kind of change does this PR introduce?\n- [ ] Bug fix (issue #__)\n- [x] New feature (issue: raw calorimeter hit associations)\n- [ ] Documentation update\n- [ ] Other: __\n\n### Please check if this PR fulfills the following:\n- [ ] Tests for the changes have been added\n- [ ] Documentation has been added / updated\n- [ ] Changes have been communicated to collaborators\n\n### Does this PR introduce breaking changes? What changes might users\nneed to make to their code?\nNo.\n\n### Does this PR change default behavior?\nNo.","shortMessageHtmlLink":"feat: produce *RawHitAssociations in CalorimeterHitDigi (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2484129052\" data-permission-text=\"Title is private\" data-url=\"https://github.com/eic/EICrecon/issues/1601\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/eic/EICrecon/pull/1601/hovercard\" href=\"https://github.com/eic/EICrecon/pull/1601\">#1601</a>)"}},{"before":"ff0bc9b8ac882a1dfd6b84a9b0f110e7b765365a","after":"faf9654e448870f3d2021c41f430ae9ceddd0499","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-09-06T19:07:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Use types in stl containers, not indices","shortMessageHtmlLink":"Use types in stl containers, not indices"}},{"before":"d8f054b265568bff2fed4f04c04302f3612b4ce1","after":"f835ccb5d603daf82baa2da589fbb5b11418cd6f","ref":"refs/heads/vertexing_group","pushedAt":"2024-09-05T16:14:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"starsdong","name":"Xin Dong","path":"/starsdong","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/11791288?s=80&v=4"},"commit":{"message":"Merge main to vertexing_group (#1608)\n\n### Briefly, what does this PR introduce?\r\n\r\n\r\n### What kind of change does this PR introduce?\r\n- [ ] Bug fix (issue #__)\r\n- [ ] New feature (issue #__)\r\n- [ ] Documentation update\r\n- [ ] Other: __\r\n\r\n### Please check if this PR fulfills the following:\r\n- [ ] Tests for the changes have been added\r\n- [ ] Documentation has been added / updated\r\n- [ ] Changes have been communicated to collaborators\r\n\r\n### Does this PR introduce breaking changes? What changes might users\r\nneed to make to their code?\r\n\r\n### Does this PR change default behavior?\r\n\r\n---------\r\n\r\nCo-authored-by: Wouter Deconinck <wdconinc@gmail.com>\r\nCo-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>\r\nCo-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>\r\nCo-authored-by: Simon Gardner <simon.gardner@glasgow.ac.uk>\r\nCo-authored-by: Alex Jentsch <alexmichaeljentsch@gmail.com>\r\nCo-authored-by: Alexander Jentsch <ajentsch@bnl.gov>\r\nCo-authored-by: Sebouh Paul <sebouh.paul@gmail.com>\r\nCo-authored-by: Barak Schmookler <bschmookler1@gmail.com>\r\nCo-authored-by: Sakib Rahman <rahmans@myumanitoba.ca>\r\nCo-authored-by: Derek M Anderson <derek.murphy.anderson@protonmail.com>\r\nCo-authored-by: Matt Posik <mposik1983@gmail.com>\r\nCo-authored-by: ShujieL <ShujieL@users.noreply.github.com>\r\nCo-authored-by: Nathan Brei <nbrei@jlab.org>\r\nCo-authored-by: Xin Dong <xdong@eic0102.rcf.bnl.gov>\r\nCo-authored-by: Xin Dong <xdong@eic0104.rcf.bnl.gov>","shortMessageHtmlLink":"Merge main to vertexing_group (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2508216101\" data-permission-text=\"Title is private\" data-url=\"https://github.com/eic/EICrecon/issues/1608\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/eic/EICrecon/pull/1608/hovercard\" href=\"https://github.com/eic/EICrecon/pull/1608\">#1608</a>)"}},{"before":"cd05f89bc7f0faa636e01d46f3c74208455fa263","after":"ff0bc9b8ac882a1dfd6b84a9b0f110e7b765365a","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-09-04T17:41:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Fix verbosity levels missed the 1st time","shortMessageHtmlLink":"Fix verbosity levels missed the 1st time"}},{"before":"fecfaaebceed42d02fd76bff31a58e955cb09dbd","after":"cd05f89bc7f0faa636e01d46f3c74208455fa263","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-09-04T17:32:38.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Use same parameter name as Island Clustering for parallel parameter","shortMessageHtmlLink":"Use same parameter name as Island Clustering for parallel parameter"}},{"before":"18d096fe4700bcaf355c0a4ff671ca2c07ef8e2c","after":"fecfaaebceed42d02fd76bff31a58e955cb09dbd","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-09-04T14:33:28.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Remove unnecessary check on if cluster is seed","shortMessageHtmlLink":"Remove unnecessary check on if cluster is seed"}},{"before":"4c5c685540f40c72f8c361b9aa8b6fdad93f9d61","after":"c621a2906da45ca5542b189110f794b997ed9efe","ref":"refs/heads/use-highest-energy-contributor-for-cluster-association","pushedAt":"2024-09-03T22:16:41.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Clean up: make preprocessor directive cleaner","shortMessageHtmlLink":"Clean up: make preprocessor directive cleaner"}},{"before":"e7c3cc72e81b3844dfb87d7a0d2829e414e7e67c","after":"bbf8da0c5c4d428b8fdff7a3cdd62cb285d44d81","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T20:16:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"simonge","name":"Simon Gardner","path":"/simonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5457667?s=80&v=4"},"commit":{"message":"Merge branch 'main' into Debug-meta","shortMessageHtmlLink":"Merge branch 'main' into Debug-meta"}},{"before":"ba810dbc3d1d0b3d7e0d4d0cb7205e02049da169","after":"e7c3cc72e81b3844dfb87d7a0d2829e414e7e67c","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T17:55:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"simonge","name":"Simon Gardner","path":"/simonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5457667?s=80&v=4"},"commit":{"message":"Apply suggestions from code review\n\nCo-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>","shortMessageHtmlLink":"Apply suggestions from code review"}},{"before":"4f4cdc74e9025dc1194a9984db555e919f7e860a","after":"ba810dbc3d1d0b3d7e0d4d0cb7205e02049da169","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T17:28:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pre-commit-ci[bot]","name":null,"path":"/apps/pre-commit-ci","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/68672?s=80&v=4"},"commit":{"message":"[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci","shortMessageHtmlLink":"[pre-commit.ci] auto fixes from pre-commit.com hooks"}},{"before":"04890b687c10c39dc6982926c29e0aca8ac13c5a","after":"4f4cdc74e9025dc1194a9984db555e919f7e860a","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T17:19:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"simonge","name":"Simon Gardner","path":"/simonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5457667?s=80&v=4"},"commit":{"message":"Fix output message","shortMessageHtmlLink":"Fix output message"}},{"before":"a597765256f625db251e67e690872907e34137cd","after":"04890b687c10c39dc6982926c29e0aca8ac13c5a","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T17:12:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"simonge","name":"Simon Gardner","path":"/simonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5457667?s=80&v=4"},"commit":{"message":"Removed debug statements","shortMessageHtmlLink":"Removed debug statements"}},{"before":"4a3882fd9d89e7dfd5c7e48ae42935856227a8f3","after":"a597765256f625db251e67e690872907e34137cd","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T15:24:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"simonge","name":"Simon Gardner","path":"/simonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5457667?s=80&v=4"},"commit":{"message":"Added debugging to meta factories and algorithm","shortMessageHtmlLink":"Added debugging to meta factories and algorithm"}},{"before":null,"after":"4a3882fd9d89e7dfd5c7e48ae42935856227a8f3","ref":"refs/heads/Debug-meta","pushedAt":"2024-09-03T15:20:15.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"simonge","name":"Simon Gardner","path":"/simonge","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5457667?s=80&v=4"},"commit":{"message":"JEventProcessorPODIO.cc: remove duplicate B0ECal* entries (#1604)\n\n### Briefly, what does this PR introduce?\nThese are already present a few lines above\n\n### What kind of change does this PR introduce?\n- [ ] Bug fix (issue #__)\n- [ ] New feature (issue #__)\n- [ ] Documentation update\n- [ ] Other: __\n\n### Please check if this PR fulfills the following:\n- [ ] Tests for the changes have been added\n- [ ] Documentation has been added / updated\n- [ ] Changes have been communicated to collaborators\n\n### Does this PR introduce breaking changes? What changes might users\nneed to make to their code?\nNo\n\n### Does this PR change default behavior?\nNo","shortMessageHtmlLink":"JEventProcessorPODIO.cc: remove duplicate B0ECal* entries (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2490015806\" data-permission-text=\"Title is private\" data-url=\"https://github.com/eic/EICrecon/issues/1604\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/eic/EICrecon/pull/1604/hovercard\" href=\"https://github.com/eic/EICrecon/pull/1604\">#1604</a>)"}},{"before":"411fedf73a8cb5e35b80f81c8ddac3ee82611fbb","after":"18d096fe4700bcaf355c0a4ff671ca2c07ef8e2c","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-09-02T23:59:45.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Clean up: make comments more descriptive","shortMessageHtmlLink":"Clean up: make comments more descriptive"}},{"before":null,"after":"8f1e085dfda414c270a2f4b2e6c131fd1a56a29b","ref":"refs/heads/pr/compelling_oic_deprecation","pushedAt":"2024-09-02T17:24:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"veprbl","name":"Dmitry Kalinkin","path":"/veprbl","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/245573?s=80&v=4"},"commit":{"message":"JEventProcessorPODIO: make `podiot:output_include_collection` deprecation warning more compelling","shortMessageHtmlLink":"JEventProcessorPODIO: make <code>podiot:output_include_collection</code> depreca…"}},{"before":"f8f447002cf581f94a17ec37dff04bac478504d9","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-1593-7f8feba7572a7b05cab02027929cd08659b1cdbd","pushedAt":"2024-09-02T15:29:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"f8f447002cf581f94a17ec37dff04bac478504d9","ref":"refs/heads/gh-readonly-queue/main/pr-1593-7f8feba7572a7b05cab02027929cd08659b1cdbd","pushedAt":"2024-09-02T15:15:50.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix: avoid division by zero by using realistic ZDC Hcal digitization (#1593)\n\n### Briefly, what does this PR introduce?\nIssue #1583 points out division by zero in cluster reconstruction. This\nis caused by the [term E / tE in the log-based weighting of\nhits](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterClusterRecoCoG.h#L33-L35),\nwhen [totalE is\nzero](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterClusterRecoCoG.cc#L204).\nThat happens when the energy in a deposited hit is zero, which happens\nwhen the [raw hit amplitude is exactly equal to the\npedestal](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterHitReco.cc#L189-L190).\nThat can only happen [when the threshold is set below the\npedestal](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterHitReco.cc#L172-L174),\nwhich is unphysical.\n\nThis PR sets the threshold for the ZDC Hcal to a physical value, based\non what it is set to for the ZDC Ecal. Happy to change it to something\nelse, but we need a realistic value here.\n\n### What kind of change does this PR introduce?\n- [x] Bug fix (issue #1583)\n- [ ] New feature (issue #__)\n- [ ] Documentation update\n- [ ] Other: __\n\n### Please check if this PR fulfills the following:\n- [ ] Tests for the changes have been added\n- [ ] Documentation has been added / updated\n- [ ] Changes have been communicated to collaborators\n\n### Does this PR introduce breaking changes? What changes might users\nneed to make to their code?\nNo.\n\n### Does this PR change default behavior?\nNo.","shortMessageHtmlLink":"fix: avoid division by zero by using realistic ZDC Hcal digitization (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2478740220\" data-permission-text=\"Title is private\" data-url=\"https://github.com/eic/EICrecon/issues/1593\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/eic/EICrecon/pull/1593/hovercard\" href=\"https://github.com/eic/EICrecon/pull/1593\">#…</a>"}},{"before":"807cb922bccf05d16602938d2817ba6a4c6f84f1","after":"961d443f1fa01dcaff3df14adef1b8681b658726","ref":"refs/heads/1583-division-by-zero-in-calorimeterclusterrecocog","pushedAt":"2024-09-02T14:56:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wdconinc","name":"Wouter Deconinck","path":"/wdconinc","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4656391?s=80&v=4"},"commit":{"message":"fix: avoid division by zero by using realistic ZDC Hcal digitization","shortMessageHtmlLink":"fix: avoid division by zero by using realistic ZDC Hcal digitization"}},{"before":"2f5e89b3268a537253b6d9b4a78e43d9146d518d","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-1593-7f8feba7572a7b05cab02027929cd08659b1cdbd","pushedAt":"2024-09-01T14:41:16.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":null,"after":"2f5e89b3268a537253b6d9b4a78e43d9146d518d","ref":"refs/heads/gh-readonly-queue/main/pr-1593-7f8feba7572a7b05cab02027929cd08659b1cdbd","pushedAt":"2024-09-01T14:28:48.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix: avoid division by zero by using realistic ZDC Hcal digitization (#1593)\n\n### Briefly, what does this PR introduce?\nIssue #1583 points out division by zero in cluster reconstruction. This\nis caused by the [term E / tE in the log-based weighting of\nhits](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterClusterRecoCoG.h#L33-L35),\nwhen [totalE is\nzero](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterClusterRecoCoG.cc#L204).\nThat happens when the energy in a deposited hit is zero, which happens\nwhen the [raw hit amplitude is exactly equal to the\npedestal](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterHitReco.cc#L189-L190).\nThat can only happen [when the threshold is set below the\npedestal](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterHitReco.cc#L172-L174),\nwhich is unphysical.\n\nThis PR sets the threshold for the ZDC Hcal to a physical value, based\non what it is set to for the ZDC Ecal. Happy to change it to something\nelse, but we need a realistic value here.\n\n### What kind of change does this PR introduce?\n- [x] Bug fix (issue #1583)\n- [ ] New feature (issue #__)\n- [ ] Documentation update\n- [ ] Other: __\n\n### Please check if this PR fulfills the following:\n- [ ] Tests for the changes have been added\n- [ ] Documentation has been added / updated\n- [ ] Changes have been communicated to collaborators\n\n### Does this PR introduce breaking changes? What changes might users\nneed to make to their code?\nNo.\n\n### Does this PR change default behavior?\nNo.","shortMessageHtmlLink":"fix: avoid division by zero by using realistic ZDC Hcal digitization (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2478740220\" data-permission-text=\"Title is private\" data-url=\"https://github.com/eic/EICrecon/issues/1593\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/eic/EICrecon/pull/1593/hovercard\" href=\"https://github.com/eic/EICrecon/pull/1593\">#…</a>"}},{"before":"41665c9b95441609197c700c4f73743bfa9d5bfe","after":"411fedf73a8cb5e35b80f81c8ddac3ee82611fbb","ref":"refs/heads/add-track-cluster-merge-algorithm","pushedAt":"2024-08-31T17:22:23.000Z","pushType":"push","commitsCount":14,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Merge main","shortMessageHtmlLink":"Merge main"}},{"before":null,"after":"5e68fb48d860feb19320aae841e4f270671aa5fc","ref":"refs/heads/insert_mip","pushedAt":"2024-08-30T22:25:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"sebouh137","name":"Sebouh Paul","path":"/sebouh137","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/20229168?s=80&v=4"},"commit":{"message":"updated MIP value in insert; also adjusted parameters of the topo clustering","shortMessageHtmlLink":"updated MIP value in insert; also adjusted parameters of the topo clu…"}},{"before":"adc3c50a51c30c8cbb435e0c589fb30ab8302741","after":null,"ref":"refs/heads/gh-readonly-queue/main/pr-1593-7f8feba7572a7b05cab02027929cd08659b1cdbd","pushedAt":"2024-08-30T21:31:55.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"}},{"before":"5bdeb5da1727cb2900d04896f4b268d14b98ff44","after":"4c5c685540f40c72f8c361b9aa8b6fdad93f9d61","ref":"refs/heads/use-highest-energy-contributor-for-cluster-association","pushedAt":"2024-08-30T20:57:57.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Use hit equality rather than checking Cell IDs","shortMessageHtmlLink":"Use hit equality rather than checking Cell IDs"}},{"before":null,"after":"adc3c50a51c30c8cbb435e0c589fb30ab8302741","ref":"refs/heads/gh-readonly-queue/main/pr-1593-7f8feba7572a7b05cab02027929cd08659b1cdbd","pushedAt":"2024-08-30T20:49:54.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"github-merge-queue[bot]","name":null,"path":"/apps/github-merge-queue","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/9919?s=80&v=4"},"commit":{"message":"fix: avoid division by zero by using realistic ZDC Hcal digitization (#1593)\n\n### Briefly, what does this PR introduce?\nIssue #1583 points out division by zero in cluster reconstruction. This\nis caused by the [term E / tE in the log-based weighting of\nhits](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterClusterRecoCoG.h#L33-L35),\nwhen [totalE is\nzero](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterClusterRecoCoG.cc#L204).\nThat happens when the energy in a deposited hit is zero, which happens\nwhen the [raw hit amplitude is exactly equal to the\npedestal](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterHitReco.cc#L189-L190).\nThat can only happen [when the threshold is set below the\npedestal](https://github.com/eic/EICrecon/blob/9d1b01ed457aa5dceb413d3dace910b2c799278b/src/algorithms/calorimetry/CalorimeterHitReco.cc#L172-L174),\nwhich is unphysical.\n\nThis PR sets the threshold for the ZDC Hcal to a physical value, based\non what it is set to for the ZDC Ecal. Happy to change it to something\nelse, but we need a realistic value here.\n\n### What kind of change does this PR introduce?\n- [x] Bug fix (issue #1583)\n- [ ] New feature (issue #__)\n- [ ] Documentation update\n- [ ] Other: __\n\n### Please check if this PR fulfills the following:\n- [ ] Tests for the changes have been added\n- [ ] Documentation has been added / updated\n- [ ] Changes have been communicated to collaborators\n\n### Does this PR introduce breaking changes? What changes might users\nneed to make to their code?\nNo.\n\n### Does this PR change default behavior?\nNo.","shortMessageHtmlLink":"fix: avoid division by zero by using realistic ZDC Hcal digitization (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2478740220\" data-permission-text=\"Title is private\" data-url=\"https://github.com/eic/EICrecon/issues/1593\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/eic/EICrecon/pull/1593/hovercard\" href=\"https://github.com/eic/EICrecon/pull/1593\">#…</a>"}},{"before":"731645dfe5055e2be54f7b1141b878a1219dd006","after":"5bdeb5da1727cb2900d04896f4b268d14b98ff44","ref":"refs/heads/use-highest-energy-contributor-for-cluster-association","pushedAt":"2024-08-30T18:47:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ruse-traveler","name":"Derek M Anderson","path":"/ruse-traveler","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/35080855?s=80&v=4"},"commit":{"message":"Report association weight in debug messages","shortMessageHtmlLink":"Report association weight in debug messages"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEr1SFHwA","startCursor":null,"endCursor":null}},"title":"Activity · eic/EICrecon"}