Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing math functions on the LLVM backend #608

Open
8 tasks
jiribenes opened this issue Sep 25, 2024 · 0 comments · May be fixed by #739
Open
8 tasks

Implement missing math functions on the LLVM backend #608

jiribenes opened this issue Sep 25, 2024 · 0 comments · May be fixed by #739
Labels
area:llvm area:stdlib good first issue Good for newcomers

Comments

@jiribenes
Copy link
Contributor

jiribenes commented Sep 25, 2024 •
edited
Loading

The following math functions/values in libraries/common/effekt.effekt are not implemented in the LLVM backend yet:

  • cos: Double => Double
  • sin: Double => Double
  • atan: Double => Double
  • tan: Double => Double
  • log: Double => Double
  • log1p: Double => Double
  • exp: Double => Double
  • _pi: Double

See #606 on how to do this, don't forget to add tests (or re-enable tests ignored on the LLVM backend).
Here's the list of all LLVM intrinsics: https://llvm.org/docs/LangRef.html#standard-c-c-library-intrinsics
mattisboeckle added a commit to mattisboeckle/effekt that referenced this issue Dec 11, 2024
@mattisboeckle
Implement missing math functions in LLVM backend
3979a04 
Implement cos, sin, atan, tan, log, log1p, _pi, exp & pow.
All functions use the LLVM intrinsics except tan & atan. They do not exist in the version of LLVM we are using.

Fixes effekt-lang#608
@mattisboeckle mattisboeckle linked a pull request Dec 11, 2024 that will close this issue
Open
mattisboeckle added a commit to mattisboeckle/effekt that referenced this issue Dec 11, 2024
@mattisboeckle
Implement missing math functions in LLVM backend
1dfcaf1 
Implement cos, sin, atan, tan, log, log1p, _pi, exp & pow.
All functions use the LLVM intrinsics except tan & atan. They do not exist in the version of LLVM we are using.

Fixes effekt-lang#608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:llvm area:stdlib good first issue Good for newcomers
Projects
Effekt Hackathon 02.10.2024
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement missing math functions in LLVM backend mattisboeckle/effekt
1 participant
@jiribenes