Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illegible captures in dark themes #32

Open
jiribenes opened this issue Nov 7, 2024 · 0 comments · May be fixed by #34
Open

Illegible captures in dark themes #32

jiribenes opened this issue Nov 7, 2024 · 0 comments · May be fixed by #34
Assignees
Labels
good first issue Good for newcomers

Comments

@jiribenes
Copy link
Contributor

Description

When using a default dark theme in VSCode, the captures are barely legible:

Dark+ / Dark Modern

Screenshot 2024-11-07 at 15 02 59

Dark VS

Screenshot 2024-11-07 at 15 04 30

Solutions

1. Change colour of captures (short-term, good first issue)

We should instead either allow the users to change the colour of captures, or use the vscode.window.activeColorTheme: ColorTheme API endpoint which can distinguish ColorTheme.kind \in { Dark, HighContrast, Light }.

We might also want to use the onDidChangeActiveColorTheme event to update this.

2. Use code inlays as a LSP feature, get captures "for free" (long-term, not a good first issue)

We could also instead use proper code inlays on the compiler / LSP server side, see effekt-lang/effekt#524.

@jiribenes jiribenes added the good first issue Good for newcomers label Nov 7, 2024
@jiribenes jiribenes linked a pull request Nov 7, 2024 that will close this issue
6 tasks
@jiribenes jiribenes self-assigned this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant