Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify common.Path and pathlib.Path #599

Open
donn opened this issue Nov 21, 2024 · 0 comments
Open

Unify common.Path and pathlib.Path #599

donn opened this issue Nov 21, 2024 · 0 comments
Labels
⛓️‍💥 breaking change This issue may require a change to OpenLane's API ✨ enhancement New feature or request
Milestone
3.0.0

Comments

@donn
Copy link
Member

donn commented Nov 21, 2024

Description

We deployed a bespoke Path class for reasons I cannot entirely recall. It is less ergonomic than the official Path class and is confusing for developers.

Proposal

For OpenLane 3.0+, we should use pathlib.Path or a subclass of it.
@donn donn added ✨ enhancement New feature or request ⛓️‍💥 breaking change This issue may require a change to OpenLane's API labels Nov 21, 2024
@donn donn added this to the 3.0.0 milestone Nov 21, 2024
@donn donn mentioned this issue Nov 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛓️‍💥 breaking change This issue may require a change to OpenLane's API ✨ enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@donn