Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PL_MAX_DISPLACEMENT_{X,Y} set atrociously high in both OpenLanes #541

Open
donn opened this issue Sep 1, 2024 · 1 comment
Open

PL_MAX_DISPLACEMENT_{X,Y} set atrociously high in both OpenLanes #541

donn opened this issue Sep 1, 2024 · 1 comment
Labels
⛓️‍💥 breaking change This issue may require a change to OpenLane's API ✨ enhancement New feature or request
Milestone
3.0.0

Comments

@donn
Copy link
Member

donn commented Sep 1, 2024

Description

The variable that governs how much an instance can be moved after global placement for legalization, PL_MAX_DISPLACEMENT_{X,Y}, is set atrociously high at 0.1mm along the Y axis and 0.5mm(!!) along the X axis.

This is the case for both OpenLanes.

Proposal

The defaults should be changed.
@donn donn added the ✨ enhancement New feature or request label Sep 1, 2024
@donn donn added this to the 3.0.0 milestone Oct 7, 2024
@donn donn added the ⛓️‍💥 breaking change This issue may require a change to OpenLane's API label Oct 7, 2024
@kareefardi
Copy link
Collaborator

Turns out that this is the default value set by OR:
https://github.com/The-OpenROAD-Project/OpenROAD/blob/c12d979536d577c22b7559b2dc346a06d687ea80/src/dpl/src/Opendp.cpp#L129-L130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⛓️‍💥 breaking change This issue may require a change to OpenLane's API ✨ enhancement New feature or request
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@kareefardi @donn