-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate Dockerfile setup [edx-platform] #11
feat: Migrate Dockerfile setup [edx-platform] #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to be merged but let's get @dianakhuang 's approval on this as well before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is mostly mergable with the exception of putting the ports back to what we were doing before.
@dianakhuang We couldn't identify what the usage of these ports are. Could you give us some context on why we are using different port addresses than the ones which are being used in local setup. |
@UsamaSadiq To be honest, I don't know why it's doing that, but the fact that it's building both production and development files that way makes me a bit more cautious. If we want to switch it to the devstack ports and do thorough testing to find out what is counting on it, I'm okay with moving forward without switching them back. |
67466f6
to
5eb828e
Compare
No description provided.