Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate Dockerfile setup [edx-platform] #11

Merged

Conversation

huniafatima-arbi
Copy link
Member

No description provided.

@huniafatima-arbi huniafatima-arbi marked this pull request as draft October 9, 2024 10:32
@huniafatima-arbi huniafatima-arbi linked an issue Oct 9, 2024 that may be closed by this pull request
@huniafatima-arbi huniafatima-arbi marked this pull request as ready for review October 14, 2024 15:57
@huniafatima-arbi huniafatima-arbi self-assigned this Oct 15, 2024
.github/workflows/push-edx-platform-images.yml Outdated Show resolved Hide resolved
.github/workflows/push-edx-platform-images.yml Outdated Show resolved Hide resolved
dockerfiles/edx-platform.Dockerfile Outdated Show resolved Hide resolved
dockerfiles/edx-platform.Dockerfile Outdated Show resolved Hide resolved
dockerfiles/edx-platform.Dockerfile Outdated Show resolved Hide resolved
dockerfiles/edx-platform.Dockerfile Outdated Show resolved Hide resolved
dockerfiles/edx-platform.Dockerfile Outdated Show resolved Hide resolved
dockerfiles/edx-platform.Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to be merged but let's get @dianakhuang 's approval on this as well before merging.

@huniafatima-arbi huniafatima-arbi changed the title feat: added dockerfile from edx-platform repo feat: Migrate Dockerfile setup [edx-platform] Oct 21, 2024
Copy link
Member

@dianakhuang dianakhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly mergable with the exception of putting the ports back to what we were doing before.

@UsamaSadiq
Copy link
Member

UsamaSadiq commented Oct 21, 2024

I think this is mostly mergable with the exception of putting the ports back to what we were doing before.

@dianakhuang We couldn't identify what the usage of these ports are. Could you give us some context on why we are using different port addresses than the ones which are being used in local setup.

@dianakhuang
Copy link
Member

@UsamaSadiq To be honest, I don't know why it's doing that, but the fact that it's building both production and development files that way makes me a bit more cautious. If we want to switch it to the devstack ports and do thorough testing to find out what is counting on it, I'm okay with moving forward without switching them back.

@huniafatima-arbi huniafatima-arbi force-pushed the huniafatima/migrate-dockerfile-setup-edx-platform branch from 67466f6 to 5eb828e Compare October 21, 2024 19:15
@huniafatima-arbi huniafatima-arbi merged commit 1680980 into main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[edx-platform] Dockerfiles and Workflow setup for Dev environment
4 participants