Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock scrolling in side-by-side view. #190

Open
danielballan opened this issue Jan 21, 2018 · 8 comments
Open

Lock scrolling in side-by-side view. #190

danielballan opened this issue Jan 21, 2018 · 8 comments

Comments

@danielballan
Copy link
Collaborator

As someone raised on Slack, it would be convenient if the left and right sides of the side-by-side view scrolled together. I think we should make it possible to turn this off interactively because its usefulness degrades as diffs diverge, but I guess that this feature would be helpful more often than not and should be on by default.

@danielballan
Copy link
Collaborator Author

Provisionally filing this as v0.0.2 because it's part of feature parity with Versionista (which recently added this feature). Feel free to re-file if you disagree.

@Mr0grog
Copy link
Member

Mr0grog commented Jan 21, 2018

I think we should make it possible to turn this off interactively because its usefulness degrades as diffs diverge

Ha, I specifically didn’t lock scrolling together early on because of this :P

I do not think this belongs in 0.0.2.

@weatherpattern
Copy link
Contributor

I agree with @Mr0grog this isn't a must have for 0.0.2.

Also, agree that unlocking/locking needs to be implemented when we do this, otherwise it will get annoying.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@stale stale bot added the stale label Jan 10, 2019
@Mr0grog
Copy link
Member

Mr0grog commented Jan 10, 2019

Still relevant.

@stale stale bot removed the stale label Jan 10, 2019
@stale
Copy link

stale bot commented Jul 9, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs. If it should not be closed, please comment! Thank you for your contributions.

@Frijol
Copy link
Contributor

Frijol commented Feb 11, 2020

Does this look like an appropriate approach? https://stackoverflow.com/questions/35238103/how-to-sync-the-scroll-bar-for-2-iframe

@Mr0grog
Copy link
Member

Mr0grog commented Feb 11, 2020

Those are the properties and events you’d need, but because the origins of the pages and web-monitoring-ui app are different, you’ll probably need to use window.postMessage to move the information back and forth between the windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants