Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding time filters to DataSetResults #63

Open
ericnost opened this issue Jan 25, 2024 · 0 comments
Open

Consider adding time filters to DataSetResults #63

ericnost opened this issue Jan 25, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ericnost
Copy link
Member

Most programs have records back to 2001 or even earlier. We already filter out records prior to 2001. We could consider adding an optional argument to store_results() for users to specify a time frame.

For instance:

ds = make_data_sets(["SDWA Serious Violators"]) # Create a DataSet for handling the data
recent_violators = ds["SDWA Serious Violators"].store_results(region_type="Watershed", region_value=["01412422"], timeframe = [2018, 2023]) # Store results for this DataSet as a DataSetResults object.
seneca_sdwa.dataframe

timeframe could take a list where the first value is the start and the second value is the stop (inclusive or exclusive).

@ericnost ericnost added the enhancement New feature or request label Jan 25, 2024
@ericnost ericnost removed this from ECHO_modules Jan 25, 2024
@ericnost ericnost added this to the v0.2.0 milestone Jan 25, 2024
@ericnost ericnost moved this to Todo in ECHO_modules Jan 25, 2024
@ericnost ericnost self-assigned this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant