Encoding error when running makemessages

[frayel]

Special chars in my .po file are causing error when i run makemessages:

File "H:\OneDrive\Documents\Workspace\workspace.python\executorbpm\venv\lib\site-packages\vinaigrette\management\commands\makemessages.py", line 171, in handle
for line in po_file:
File "C:\Dev\Python3.7\lib\encodings\cp1252.py", line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x81 in position 3547: character maps to

It was solved changing
vinaigrette\management\commands\makemessages.py

line 168 to:
with open(po_path, encoding='utf-8') as po_file:

line 194 to:
with open(po_path, 'w', encoding='utf-8') as po_file:

[jordiecometrica]

I don't understand the proposed fix. How did you come to this conclusion?

[jordiecometrica]

Oh, I see, the default encoding is platform-dependent. It's probably UTF-16 or something on Windows.

[frayel]

Yes, i am using it at windows. Probably cp1252...
I don't know if this is the best solution. But worked here.. :)

Thank you, django-vinaigrette is being very useful here

[EParisot]

is it gonna be an official patch for this issue ?

[Ultraspider]

Hi.
I've been bitten by this more than once on windows as well.
Looking at Django's own makemessage.py command file, every call to open() has encoding='utf-8' specified.
So I guess it would make sense to apply the same behavior when handling the .po file made by those calls.