Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename refactoring takes the first occurance - even in comment - to start linked-editing #2905

Open
frankbenoit opened this issue Jan 10, 2024 · 0 comments
Open

Rename refactoring takes the first occurance - even in comment - to start linked-editing #2905

frankbenoit opened this issue Jan 10, 2024 · 0 comments
Labels
help_wanted

Comments

@frankbenoit
Copy link
Contributor 

// MyClass
class MyClass { ...

Starting renaming of MyClass will start the renaming in the comment.

org.eclipse.xtext.ui.refactoring2.rename.DefaultLinkedPositionGroupCalculator2.createLinkedGroupFromReplaceEdits(List, XtextEditor, String, SubMonitor)
This takes the whole text of the "class", which is inclusive the comment. Then searches in there for "MyClass" and finds the position of the comment as the first (and only) result position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help_wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdietrich @frankbenoit