Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed z_sample_* methods #464

Closed
sashacmc opened this issue Jun 26, 2024 · 1 comment
Closed

Add missed z_sample_* methods #464

sashacmc opened this issue Jun 26, 2024 · 1 comment
Labels
release Part of the next release

Comments

@sashacmc
Copy link
Member

sashacmc commented Jun 26, 2024

Describe the release item

@sashacmc sashacmc added the release Part of the next release label Jun 26, 2024
@DenisBiryukov91
Copy link
Contributor

DenisBiryukov91 commented Jul 10, 2024

z_sample_timestamp returns a const pointer to timestamp in zenoh-c and value in pico. We should decide on which approach to keep. Returning pointer has the advantage that we can return null when no timestamp is associated with the sample (Zenoh-rust returns Option<&Timestamp>)

@sashacmc sashacmc removed their assignment Jul 12, 2024
@gabrik gabrik closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Part of the next release
Projects
Status: Done
Development

No branches or pull requests

3 participants