Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZenohUTransport::QueryHandler() does not fill the format field in the payload #53

Open
sanjok-itin opened this issue May 21, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@sanjok-itin
Copy link

sanjok-itin commented May 21, 2024

RPC server receives the payload with the default (RAW) format instead of the client sent format.

@gregmedd gregmedd added the bug Something isn't working label May 21, 2024
@gregmedd
Copy link
Contributor

gregmedd commented May 21, 2024

@sanjok-itin - Can you provide more information about the test you ran? Or some simple example code that reproduces the issue so we can see it? Thanks!

It would also be helpful to understand the impact and severity. Is this an urgent fix for right now, or can it wait for the transport rewrite coming for uP 1.5.8?

@sanjok-itin
Copy link
Author

my test is a bit complicated, the source code - https://github.com/eclipse-uprotocol/up-client-zenoh-cpp/blob/main/lib/src/zenohUTransport.cpp#L462
The Payload object is constructed with the actual payload, but the format field is not attached.

I have a workaround of encoding the format inside the payload buffer, so the issue is not urgent, just the workaround requires additional buffer copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants