Detect ci.yml changes when restoring caches #35
Comments
|
Looks like GITHUB_WORKFLOW_SHA can fix this |
gregmedd
added a commit
to gregmedd/up-transport-zenoh-cpp
that referenced
this issue
Apr 15, 2024
GitHub will fall back to the cache from the target branch of a PR if it fails to find a cache for the source branch of a PR. This causes issues if the PR is changing the ci.yml file (see eclipse-uprotocol#32) without one of the dependency repos changing (up-cpp and zenoh-c). This change adds the SHA of the workflow file to the cache key so that changes to ci.yml will invalidate the caches. While this reduces the value of the caches when iterating on ci.yml changes, a developer working in ci.yml would have the ability to remove this temporarily if needed.
gregmedd
added a commit
to gregmedd/up-transport-zenoh-cpp
that referenced
this issue
Apr 15, 2024
gregmedd
added a commit
to gregmedd/up-transport-zenoh-cpp
that referenced
this issue
Apr 15, 2024
GitHub will fall back to the cache from the target branch of a PR if it fails to find a cache for the source branch of a PR. This causes issues if the PR is changing the ci.yml file (see eclipse-uprotocol#32) without one of the dependency repos changing (up-cpp and zenoh-c). This change adds the SHA of the workflow file to the cache key so that changes to ci.yml will invalidate the caches. While this reduces the value of the caches when iterating on ci.yml changes, a developer working in ci.yml would have the ability to remove this temporarily if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#33 introduced caching for prerequisite package builds. However, if a change is made to the
ci.ymlin this repo without a corresponding change in one of the external repos, the cache will override and result in a bad build. This can be seen in #32 (https://github.com/eclipse-uprotocol/up-client-zenoh-cpp/actions/runs/8692147864) - GitHub actions will happily fall back to the cache from the main branch in the absence of one from the PR branch.A temporary workaround would be to clear the cache on main if a PR is changing the CI configuration, but that requires intervention from a committer to unblock other contributors.
A full fix would find a way to get the hash of the ci.yml file and embed that into the cache key to prevent this from happening in the future.
The text was updated successfully, but these errors were encountered: