feat(binding_mqtt): support MQTT URI scheme #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
force-pushed
the
mqtt-uri-scheme
branch
2 times, most recently
from
e5c9360 to
1d9ece4
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 60.41% 52.16% -8.25%
==========================================
Files 70 70
Lines 2185 2189 +4
==========================================
- Hits 1320 1142 -178
- Misses 865 1047 +182
☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
mqtt-uri-scheme
branch
from
d8e8744 to
2cf13d1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 63.34% 63.22% -0.12%
==========================================
Files 78 78
Lines 2275 2279 +4
==========================================
Hits 1441 1441
- Misses 834 838 +4 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
mqtt-uri-scheme
branch
2 times, most recently
from
d5a6b06 to
9113b47
Compare
JKRhb
force-pushed
the
mqtt-uri-scheme
branch
from
9113b47 to
62d95d3
Compare
JKRhb
force-pushed
the
mqtt-uri-scheme
branch
from
62d95d3 to
40eaea2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the use of the MQTT URI scheme that is currently being discussed in w3c/wot-binding-templates#292.
An open question here is how to deal with the
topicvocabulary term. With the implementation in this PR, it is being treated as an "override", but maybe it also becomes obsolete when the new URI scheme is in place.