Keybinding not mapped correctly depending on Keyboard Layout

[jfaltermeier]

Bug Description:

Keybindings including AltGr do not work (on German keyboard layout at least)

Steps to Reproduce:

1. Use German keyboard layout
2. Add a keybinding for e.g. "Ctrl+["
3. Keybinding is not working. In the UI it shows as "Ctrl+ü", which actually works. (I think ü is [ on US layout)
4. When I click to edit the binding again, it shows "Ctrl+[" though.

Additional Information

I'm not sure if there is a general issue with detecting Alt Gr/Figuring out the required keys for each layout.
However I think we shouldn't map to wrong keybindings at least.

• Operating System: Ubuntu
• Theia Version: master

[rschnekenbu]

I don't know if this is related, but I get a lot of errors at startup about key bindings: [1175888:0709/134222.061193:ERROR:accelerator_util.cc(23)] The accelerator string can only contain ASCII characters, invalid string: "Ctrl+Shift+à"
I can reproduce the issue with a French keyboard too, with the keybindings containing ².