[pivot] ToStringVisitor can resolve proxies

[eclipse-ocl-bot]

| --- | --- |
| Bugzilla Link | 583347 |
| Status | NEW |
| Importance | P3 normal |
| Reported | Jun 13, 2024 06:11 EDT |
| Modified | Jun 19, 2024 04:31 EDT |
| Reporter | Ed Willink |

Description

ToStringVisitor is a useful debugging aid, but it uses methods such as getReferredLiteral that resolve proxies. This may sometimes be useful, but more often is confusing since the addition of debug changes the state. Worse if used in for instance an unload(), the resolution may provoke a load during unload and even a multi-content CME for getAppliedProfile. Debug toString() added to debug one problem can be ofuscated by extra bugs from the debug.

[eclipse-ocl-bot]

By Ed Willink on Jun 13, 2024 06:37

testImport_CompleteOCL_UML fails badly once

if ("my::AType::referenced() : my::BType[?]".equals(toString())) {\
getClass();				// XXX\
}

added to PivotObjectImpl.resetESObject()

[eclipse-ocl-bot]

By Ed Willink on Jun 19, 2024 04:31

Making ToStringVisitor safe is hard since basicGetXXX for required features needs a cast to the Impl class. Harder is to fix eContainer and getType in the hierarchical name.

Simpler, set a trap for invocation of PivotObjectImpl.eResolveProxy while ToStringVisitor is active. But that costs for every eResolveProxy.

Maybe a trap for ToStringVisitor activation if e.g. unload has declared an immutable region e.g. when PivotEnvironmentFactory.isDisposing()