[pivot] Complete invariants lack mutual common subexpression elimination

[eclipse-ocl-bot]

| --- | --- |
| Bugzilla Link | 583242 |
| Status | NEW |
| Importance | P3 normal |
| Reported | May 10, 2024 06:42 EDT |
| Modified | May 10, 2024 06:43 EDT |
| Depends on | 520440 |
| See also | 583197 |
| Reporter | Ed Willink |

Description

The provocative testValidate_Validate_completeocl, after working on Bug 583197, loads the same Constraint from both Validate.ecore and Validate.oclinecore. Validation failures are therefore reported twice.

For now rewrite the test to expect double validation.

Longer term, the better Bug 520440 symbolic analysis should allow the two copies of an invariant to be pruned by common subexpression elimination.

More generally still, the suite of invariants/copnstraints should be optimized as a composite AND of each invariant prioritized so that 'guards' are evaluated first to avoid gratuitous downstream failures.