From c2b06761d00a05026f9df1ccd518d633a0e56b48 Mon Sep 17 00:00:00 2001
From: Tobias Ortmayr <tortmayr@eclipsesource.com>
Date: Thu, 29 Aug 2024 16:15:05 +0200
Subject: [PATCH] Address review feedback

---
 .../dependency-reduced-pom.xml                | 156 ------------------
 .../eclipse/glsp/layout/ElkLayoutEngine.java  |   3 +-
 2 files changed, 1 insertion(+), 158 deletions(-)
 delete mode 100644 examples/org.eclipse.glsp.example.workflow/dependency-reduced-pom.xml

diff --git a/examples/org.eclipse.glsp.example.workflow/dependency-reduced-pom.xml b/examples/org.eclipse.glsp.example.workflow/dependency-reduced-pom.xml
deleted file mode 100644
index b650b922..00000000
--- a/examples/org.eclipse.glsp.example.workflow/dependency-reduced-pom.xml
+++ /dev/null
@@ -1,156 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
-  <parent>
-    <artifactId>org.eclipse.glsp.parent</artifactId>
-    <groupId>org.eclipse.glsp</groupId>
-    <version>2.3.0-SNAPSHOT</version>
-    <relativePath>../../pom.xml</relativePath>
-  </parent>
-  <modelVersion>4.0.0</modelVersion>
-  <groupId>org.eclipse.glsp.example</groupId>
-  <artifactId>org.eclipse.glsp.example.workflow</artifactId>
-  <packaging>${package-type}</packaging>
-  <description>GLSP Workflow Server</description>
-  <url>https://www.eclipse.org/glsp</url>
-  <developers>
-    <developer>
-      <name>Eclipse GLSP Project</name>
-      <email>glsp-dev@eclipse.org</email>
-      <organization>Eclipse GLSP</organization>
-      <organizationUrl>https://projects.eclipse.org/projects/ecd.glsp</organizationUrl>
-    </developer>
-  </developers>
-  <licenses>
-    <license>
-      <name>Eclipse Public License - v 2.0</name>
-      <url>http://www.eclipse.org/legal/epl-v20.html</url>
-      <distribution>repo</distribution>
-    </license>
-  </licenses>
-  <scm>
-    <connection>scm:git@github.com:eclipse-glsp/glsp-server.git</connection>
-    <developerConnection>scm:git@github.com:eclipse-glsp/glsp-server.git</developerConnection>
-    <url>https://github.com/eclipse-glsp/glsp-server</url>
-  </scm>
-  <profiles>
-    <profile>
-      <id>m2</id>
-      <build>
-        <plugins>
-          <plugin>
-            <artifactId>maven-deploy-plugin</artifactId>
-            <version>${maven.deploy.version}</version>
-            <configuration>
-              <skip>false</skip>
-            </configuration>
-          </plugin>
-          <plugin>
-            <groupId>org.codehaus.mojo</groupId>
-            <artifactId>build-helper-maven-plugin</artifactId>
-            <version>${buildhelper.maven.version}</version>
-            <executions>
-              <execution>
-                <id>add-resource</id>
-                <phase>generate-resources</phase>
-                <goals>
-                  <goal>add-resource</goal>
-                </goals>
-                <configuration>
-                  <resources>
-                    <resource>
-                      <directory>model</directory>
-                      <targetPath>model</targetPath>
-                    </resource>
-                  </resources>
-                </configuration>
-              </execution>
-            </executions>
-          </plugin>
-        </plugins>
-      </build>
-      <properties>
-        <package-type>jar</package-type>
-      </properties>
-    </profile>
-    <profile>
-      <id>fatjar</id>
-      <build>
-        <plugins>
-          <plugin>
-            <artifactId>maven-shade-plugin</artifactId>
-            <version>${maven.shade.version}</version>
-            <executions>
-              <execution>
-                <phase>package</phase>
-                <goals>
-                  <goal>shade</goal>
-                </goals>
-              </execution>
-            </executions>
-            <configuration>
-              <transformers>
-                <transformer>
-                  <mainClass>org.eclipse.glsp.example.workflow.launch.WorkflowServerLauncher</mainClass>
-                  <manifestEntries>
-                    <Multi-Release>true</Multi-Release>
-                  </manifestEntries>
-                </transformer>
-              </transformers>
-              <artifactSet>
-                <excludes>
-                  <exclude>jakarta.websocket:jakarta.websocket-api</exclude>
-                  <exclude>javax.websocket:javax.websocket-api</exclude>
-                  <exclude>log4j:log4j</exclude>
-                </excludes>
-              </artifactSet>
-              <filters>
-                <filter>
-                  <artifact>*:*</artifact>
-                  <excludes>
-                    <exclude>META-INF/MANIFEST.MF</exclude>
-                    <exclude>META-INF/DEPENDENCIES</exclude>
-                    <exclude>META-INF/ECLIPSE_*</exclude>
-                    <exclude>META-INF/LICENSE*</exclude>
-                    <exclude>META-INF/services/javax.servlet.ServletContainerInitializer</exclude>
-                    <exclude>META-INF/services/jakarta.servlet.ServletContainerInitializer*</exclude>
-                    <exclude>META-INF/services/org.eclipse.jetty.webapp.Configuration*</exclude>
-                    <exclude>META-INF/services/org.eclipse.elk.core.data.ILayoutMetaDataProvider*</exclude>
-                    <exclude>META-INF/versions/9/module-info.class</exclude>
-                    <exclude>META-INF/NOTICE*</exclude>
-                    <exclude>.options</exclude>
-                    <exclude>.api_description</exclude>
-                    <exclude>*.profile</exclude>
-                    <exclude>*.html</exclude>
-                    <exclude>about.*</exclude>
-                    <exclude>about_files/*</exclude>
-                    <exclude>plugin.xml</exclude>
-                    <exclude>modeling32.png</exclude>
-                    <exclude>systembundle.properties</exclude>
-                    <exclude>profile.list</exclude>
-                    <exclude>module-info.class</exclude>
-                    <exclude>plugin.properties</exclude>
-                    <exclude>**/*._trace</exclude>
-                    <exclude>**/*.g</exclude>
-                    <exclude>**/*.tokens</exclude>
-                    <exclude>**/*.mwe2</exclude>
-                    <exclude>**/*.xtext</exclude>
-                    <exclude>**/*.xtextbin</exclude>
-                    <exclude>META-INF/*.SF</exclude>
-                    <exclude>META-INF/*.RSA</exclude>
-                    <exclude>META-INF/*.INF</exclude>
-                  </excludes>
-                </filter>
-              </filters>
-              <shadedArtifactAttached>true</shadedArtifactAttached>
-              <shadedClassifierName>glsp</shadedClassifierName>
-              <minimizeJar>false</minimizeJar>
-            </configuration>
-          </plugin>
-        </plugins>
-      </build>
-    </profile>
-  </profiles>
-  <properties>
-    <package-type>eclipse-plugin</package-type>
-  </properties>
-</project>
diff --git a/plugins/org.eclipse.glsp.layout/src/org/eclipse/glsp/layout/ElkLayoutEngine.java b/plugins/org.eclipse.glsp.layout/src/org/eclipse/glsp/layout/ElkLayoutEngine.java
index 5e349821..387ab2d4 100644
--- a/plugins/org.eclipse.glsp.layout/src/org/eclipse/glsp/layout/ElkLayoutEngine.java
+++ b/plugins/org.eclipse.glsp.layout/src/org/eclipse/glsp/layout/ElkLayoutEngine.java
@@ -273,8 +273,7 @@ protected void handleClientLayout(final GBoundsAware element, final GLayouting s
     */
    protected void resolveReferences(final LayoutContext context) {
       // Per default a map will resize when 75% of its capacticy is filled. By dividing the expected size with the load
-      // factor
-      // we can create a map with enough capacity to avoid resizing
+      // factor we can create a map with enough capacity to avoid resizing
       int initialCapactiy = (int) Math.ceil(context.shapeMap.size() / 0.75);
       Map<String, ElkConnectableShape> id2NodeMap = new HashMap<>(initialCapactiy);